github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-11-13 06:14:30 -06:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[BUG] Auth cannot be changed from the default / Save Users & Roles button fails to save and throws an error #63

New Issue
Closed
opened 2025-11-13 11:48:54 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-13 11:48:54 -06:00
Owner
Copy Link
Copy Source

Originally created by @gokussjx on GitHub (Feb 5, 2025).

Current Behavior: On hitting Save Users & Roles button, this error pops up and the save never succeeds:

Failed to set roles
Resource with that domain already exists

Image

Expected Behavior: As per the doc:

If you would like to disable Pangolin auth, you can disable the Use Platform SSO toggle.

In other words, disabling the foregoing option and hitting save should save successfully without any errors. Primarily, the Save Users & Roles button should save the configured option.

Image
(Thanks @hhftechnology for the screenshot^)

Steps to Reproduce:

  1. Download the latest version of the application. (v1.0.0 beta12)
  2. Install the application via the standard process from the doc.
  3. Create a few resources (may be 5, this bit isn't deterministic)
  4. Navigate to the Resources page > (pick a resource) > Authentication > Hit Save Users & Roles
  5. Try toggling the SSO switch or saving as is, but attempt to save at least 5 times.
  6. You should see a red error banner at bottom right.

Environment:

  • OS: Ubuntu
  • Application Version: v1.0.0 beta12

Additional Information:

  • Screenshot of error message attached.
  • Discord thread: link
  • Bug reproducible by @hhftechnology in the channel
Originally created by @gokussjx on GitHub (Feb 5, 2025). **Current Behavior:** On hitting `Save Users & Roles` button, this error pops up and the save never succeeds: > **Failed to set roles** > Resource with that domain already exists ![Image](https://github.com/user-attachments/assets/328f1b17-1f81-4dd8-a9f6-4399a09d8208) **Expected Behavior:** As per the [doc](https://docs.fossorial.io/Getting%20Started/quick-setup#5-add-targets-and-authentication): > If you would like to disable Pangolin auth, you can disable the `Use Platform SSO` toggle. In other words, disabling the foregoing option and hitting save should save successfully without any errors. Primarily, the `Save Users & Roles` button should save the configured option. ![Image](https://github.com/user-attachments/assets/da0e51bf-209b-44a6-a39f-bb5744fad1b1) (Thanks @hhftechnology for the screenshot^) **Steps to Reproduce:** 1. Download the latest version of the application. (`v1.0.0 beta12`) 2. Install the application via the standard process from the doc. 3. Create a few resources (may be 5, this bit isn't deterministic) 4. Navigate to the Resources page > (pick a resource) > Authentication > Hit `Save Users & Roles` 5. Try toggling the SSO switch or saving as is, but attempt to save at least 5 times. 6. You should see a red error banner at bottom right. **Environment:** - OS: Ubuntu - Application Version: v1.0.0 beta12 **Additional Information:** - Screenshot of error message attached. - Discord thread: [link](https://discord.com/channels/1325658630518865980/1336625963798364232/1336625963798364232) - Bug reproducible by @hhftechnology in the channel
GiteaMirror commented 2025-11-13 11:48:55 -06:00
Author
Owner
Copy Link
Copy Source

@miloschwartz commented on GitHub (Feb 5, 2025):

Hey, thanks for finding this - was a missing if statement 😑.

I patched beta.12 with a fix for this. Can you re-pull the 1.0.0-beta.12 image?

I think we might introduce some kind of early testing program for people to use pre-build versions so we can find this stuff sooner.

Edit: Seemed to only affect base domain resources.

@miloschwartz commented on GitHub (Feb 5, 2025): Hey, thanks for finding this - was a missing if statement 😑. I patched beta.12 with a fix for this. Can you re-pull the 1.0.0-beta.12 image? I think we might introduce some kind of early testing program for people to use pre-build versions so we can find this stuff sooner. Edit: Seemed to only affect base domain resources.
GiteaMirror commented 2025-11-13 11:48:55 -06:00
Author
Owner
Copy Link
Copy Source

@nixielectra commented on GitHub (Feb 5, 2025):

Latest beta.12 image fixed this issue for me, was on subdomain resource.

@nixielectra commented on GitHub (Feb 5, 2025): Latest beta.12 image fixed this issue for me, was on subdomain resource.
GiteaMirror commented 2025-11-13 11:48:55 -06:00
Author
Owner
Copy Link
Copy Source

@manilx commented on GitHub (Feb 5, 2025):

Fixed, for me too. 👍

@manilx commented on GitHub (Feb 5, 2025): Fixed, for me too. 👍
GiteaMirror commented 2025-11-13 11:48:55 -06:00
Author
Owner
Copy Link
Copy Source

@gokussjx commented on GitHub (Feb 5, 2025):

Can confirm, all working now, thanks!

+1 to an eartly-testing program. Additionally, unit & regression testing would be super useful as the project gets more and more feature-rich 👀

@gokussjx commented on GitHub (Feb 5, 2025): Can confirm, all working now, thanks! +1 to an eartly-testing program. Additionally, unit & regression testing would be super useful as the project gets more and more feature-rich 👀
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#63