github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2172] [MERGED] Fix: confirm delete button working without confirm text #2893

New Issue
Closed
opened 2026-04-16 09:40:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 09:40:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2172
Author: @ruxenburg
Created: 12/27/2025
Status: ✅ Merged
Merged: 12/28/2025
Merged by: @oschwartz10612

Base: main ← Head: fix-confirm-delete-button-working-without-confirm-text

📝 Commits (2)

  • f5eedff Fix confirm delete button to require confirmation text before enabling it.
  • 412e125 improve delete confirmation logic

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/components/ConfirmDeleteDialog.tsx (+4 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR prevents deletions unless the required confirmation text has been entered. (this has been tested on chrome and Firefox browser)

How to test?

  1. add anything deletable that would trigger the \src\components\ConfirmDeleteDialog.tsx
  2. attempt to delete it without the confirm text (should not work anymore)
  3. attempt it with wrong text (should not work)
  4. attempt it with correct text (should work)

ui changes

ui changes [before]

image

ui changes [after]

image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2172 **Author:** [@ruxenburg](https://github.com/ruxenburg) **Created:** 12/27/2025 **Status:** ✅ Merged **Merged:** 12/28/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix-confirm-delete-button-working-without-confirm-text` --- ### 📝 Commits (2) - [`f5eedff`](https://github.com/fosrl/pangolin/commit/f5eedff2990f8df56a1509dc4136b90782dc50e8) Fix confirm delete button to require confirmation text before enabling it. - [`412e125`](https://github.com/fosrl/pangolin/commit/412e1252350b79efd5ca7d8cafd2e75c77366675) improve delete confirmation logic ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/components/ConfirmDeleteDialog.tsx` (+4 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This PR prevents deletions unless the required confirmation text has been entered. (this has been tested on chrome and Firefox browser) ## How to test? 1. add anything deletable that would trigger the `\src\components\ConfirmDeleteDialog.tsx` 2. attempt to delete it without the confirm text (should not work anymore) 3. attempt it with wrong text (should not work) 4. attempt it with correct text (should work) ## ui changes ### ui changes [before] <img width="779" height="637" alt="image" src="https://github.com/user-attachments/assets/249f817c-cd04-44a8-9b9c-5053809574e9" /> ### ui changes [after] <img width="777" height="635" alt="image" src="https://github.com/user-attachments/assets/0c94f9a2-b381-4487-94bb-88bcf97488d5" /> <img width="788" height="648" alt="image" src="https://github.com/user-attachments/assets/f1e595b5-762d-4164-b2c3-9572c3f7682a" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:40:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#2893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?