[PR #2045] [MERGED] fix: full domain should be updated when the form is saved on resource proxy page #2839

Closed
opened 2026-04-16 09:38:13 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2045
Author: @Fredkiss3
Created: 12/11/2025
Status: Merged
Merged: 12/11/2025
Merged by: @oschwartz10612

Base: devHead: fix/update-full-domain-on-resource-page


📝 Commits (1)

  • 181612c 🐛 full domain should be updated when the form is saved

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

I noticed a bug where when updating a resource domain, it would not be reflected in the infobox, and when going back and forth to the homepage, the value of the full domain would revert to the previous value.

The domain is correctly updated on the backend though, since we can see that if we refresh the page, it would reflect the actual value we updated.

The fix: calling updateResource() with the updated value, not the previous value of the resource.

screenshots

video

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2045 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/update-full-domain-on-resource-page` --- ### 📝 Commits (1) - [`181612c`](https://github.com/fosrl/pangolin/commit/181612ce250b0a60c2b5ec81e44c961a54e95f42) 🐛 full domain should be updated when the form is saved ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description I noticed a bug where when updating a resource domain, it would not be reflected in the infobox, and when going back and forth to the homepage, the value of the full domain would revert to the previous value. The domain is correctly updated on the backend though, since we can see that if we refresh the page, it would reflect the actual value we updated. The fix: calling `updateResource()` with the updated value, not the previous value of the resource. ## screenshots <table> <tr> <td align="center"> video </td> </tr> <tr> <td> <video src="https://github.com/user-attachments/assets/ae0fff1f-dfe1-4fdb-9325-15f620ca0a7d"></video> </td> </tr> </table> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 09:38:13 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#2839