[PR #6262] [CLOSED] fix: get userinfo from endpoint, not only from token #8646

Closed
opened 2025-11-11 18:01:55 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/6262
Author: @alvarolopez
Created: 10/18/2024
Status: Closed

Base: devHead: userinfo


📝 Commits (1)

  • 7713411 fix: get userinfo from endpoint, not only from token

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/main.py (+1 -1)

📄 Description

The OpenID Connect Specification does not enforce that userinfo claims are included in the ID token "ID Tokens MAY contain other Claims" 1. Some providers do not include userinfo claims in the ID token, therefore it is needed to perform an additional call to the userinfo endpoint 2 to obtain them,

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • OpenID Connect userinfo claims may not be present in ID token as the specification does not enforce it, therefore Open WebUI cannot be used with providers not including them.

Fixed

  • Use OpenID Conect userinfo from endpoints to get userinfo claims, nor relying on ID token containing them.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/6262 **Author:** [@alvarolopez](https://github.com/alvarolopez) **Created:** 10/18/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `userinfo` --- ### 📝 Commits (1) - [`7713411`](https://github.com/open-webui/open-webui/commit/7713411e3824b44451d29ca2ad90fb6d70eea32c) fix: get userinfo from endpoint, not only from token ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+1 -1) </details> ### 📄 Description The OpenID Connect Specification does not enforce that userinfo claims are included in the ID token "ID Tokens MAY contain other Claims" [1]. Some providers do not include userinfo claims in the ID token, therefore it is needed to perform an additional call to the userinfo endpoint [2] to obtain them, [1]: https://openid.net/specs/openid-connect-core-1_0.html#IDToken [2]: https://openid.net/specs/openid-connect-core-1_0.html#UserInfo # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - OpenID Connect userinfo claims may not be present in ID token as the specification does not enforce it, therefore Open WebUI cannot be used with providers not including them. ### Fixed - Use OpenID Conect userinfo from endpoints to get userinfo claims, nor relying on ID token containing them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:01:55 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8646