[PR #11394] [MERGED] fix: logit_bias bug in workspace models #61579

New Issue

GiteaMirror · 2026-05-06T05:06:48-05:00

GiteaMirror commented

2026-05-06 05:06:48 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11394
Author: @dannyl1u
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/8/2025
Merged by: @tjbck

Base: dev ← Head: fix/logit-bias-workspace-models

📝 Commits (1)

3c6a834 fix: logit_bias in workspace models

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/openai.py (+4 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixes #11263: Non-Workspace and Workspace models use different backend functions to call the API, which caused formatting to only apply to non-Workspace models. This PR ensures both types of models use the correct function and get the proper formatting

Fixed

Customized workspace models now work when logit_bias parameter is added

Additional Information

Upon further thought, it appears it would be better to do this "formatting/conversion" earlier than when the api call is made, since currently the JSON Preview still shows a string rather than an object, so if the user decides the copy/paste the JSON Preview, it shows what is actual sent in the payload.

Screenshots or Videos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11394 **Author:** [@dannyl1u](https://github.com/dannyl1u) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 3/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/logit-bias-workspace-models` --- ### 📝 Commits (1) - [`3c6a834`](https://github.com/open-webui/open-webui/commit/3c6a834ff4d75341871aa0f7fbd4ad5fb2227841) fix: logit_bias in workspace models ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/openai.py` (+4 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixes #11263: Non-Workspace and Workspace models use different backend functions to call the API, which caused formatting to only apply to non-Workspace models. This PR ensures both types of models use the correct function and get the proper formatting ### Fixed - Customized workspace models now work when `logit_bias` parameter is added --- ### Additional Information - Upon further thought, it appears it would be better to do this "formatting/conversion" earlier than when the api call is made, since currently the JSON Preview still shows a string rather than an object, so if the user decides the copy/paste the JSON Preview, it shows what is actual sent in the payload. ### Screenshots or Videos <img width="1136" alt="image" src="https://github.com/user-attachments/assets/5d3e8adc-220f-4c9c-8802-bf00fd329982" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 05:06:48 -05:00

GiteaMirror closed this issue

2026-05-06 05:06:50 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#61579