[PR #17906] [CLOSED] fix: use correct discovery_url variable in OAuth discovery loop #11394

New Issue

GiteaMirror · 2025-11-11T19:30:41-06:00

GiteaMirror commented

2025-11-11 19:30:41 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17906
Author: @hsuyuming
Created: 9/29/2025
Status: ❌ Closed

Base: dev ← Head: fix/fetch-all-of-discovery-url

📝 Commits (1)

76edd02 fix: use correct discovery_url variable in OAuth discovery loop

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/configs.py (+1 -1)

📄 Description

Discussion: https://github.com/open-webui/open-webui/discussions/17905
Issue: https://github.com/open-webui/open-webui/issues/17904

Pull Request Checklist

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? No
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? Yes
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The fix corrects an issue in the verify_tool_servers_config function where only the first discovery URL was being used (discovery_urls[0]) instead of the current URL in the iteration (discovery_url). This change ensures all discovery URLs are properly tried in sequence until a successful connection is established, improving the reliability of OAuth 2.1 server discovery.

Fixed

We fix the issue in the verify_tool_servers_config function so that all discovery URLs are now attempted in sequence until a successful connection is made.

Screenshots or Videos

Before:

After:

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17906 **Author:** [@hsuyuming](https://github.com/hsuyuming) **Created:** 9/29/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/fetch-all-of-discovery-url` --- ### 📝 Commits (1) - [`76edd02`](https://github.com/open-webui/open-webui/commit/76edd0242fc4a29f4eeaab1f5c20bc089aa598da) fix: use correct discovery_url variable in OAuth discovery loop ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/configs.py` (+1 -1) </details> ### 📄 Description Discussion: https://github.com/open-webui/open-webui/discussions/17905 Issue: https://github.com/open-webui/open-webui/issues/17904 # Pull Request Checklist - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? No - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? Yes - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - The fix corrects an issue in the verify_tool_servers_config function where only the first discovery URL was being used (discovery_urls[0]) instead of the current URL in the iteration (discovery_url). This change ensures all discovery URLs are properly tried in sequence until a successful connection is established, improving the reliability of OAuth 2.1 server discovery. ### Fixed - We fix the issue in the verify_tool_servers_config function so that all discovery URLs are now attempted in sequence until a successful connection is made. --- ### Screenshots or Videos Before: <img width="1482" height="533" alt="Screenshot 2025-09-29 at 5 08 42 PM" src="https://github.com/user-attachments/assets/12597231-883f-4074-a94e-f81408ccf9f9" /> After: <img width="1434" height="785" alt="Screenshot 2025-09-29 at 5 11 06 PM" src="https://github.com/user-attachments/assets/514d88d3-931f-4ecd-84b8-399e177e57cd" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:30:41 -06:00

GiteaMirror closed this issue

2025-11-11 19:30:41 -06:00

GiteaMirror referenced this issue

2026-04-20 04:21:05 -05:00

[PR #11394] [MERGED] fix: logit_bias bug in workspace models #22723

GiteaMirror referenced this issue

2026-04-25 11:25:13 -05:00

[PR #11394] [MERGED] fix: logit_bias bug in workspace models #38353

GiteaMirror referenced this issue

2026-04-29 20:18:03 -05:00

[PR #11394] [MERGED] fix: logit_bias bug in workspace models #45771