de3d490 fix: RegExp "invalid group specifier name" exception on Safari < 16.4 (#3306, #3371)
📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝src/lib/utils/index.ts (+1 -1)
📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
This PR fixed the issue of regex exception for Safari before 16.4 (iOS 16.4), where regex lookbehind syntax is not supported. Before this change, devices that are not supported by or updated to iOS 16.4 or later are unable to use Open WebUI chat, e.g. iPhone 7.
Fixed
RegExp "invalid group specifier name" exception on Safari < 16.4 (#3306, #3371)
Additional Information
This issue was first observed in Open WebUI 0.3.5.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/3564
**Author:** [@wanderingmeow](https://github.com/wanderingmeow)
**Created:** 7/1/2024
**Status:** ✅ Merged
**Merged:** 7/1/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix-regexp-safari-before-16.4`
---
### 📝 Commits (1)
- [`de3d490`](https://github.com/open-webui/open-webui/commit/de3d49000e89f5cb88995627fd257ddaf0355e66) fix: RegExp "invalid group specifier name" exception on Safari < 16.4 (#3306, #3371)
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/utils/index.ts` (+1 -1)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [X] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [X] **Description:** Provide a concise description of the changes made in this pull request.
- [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [X] **Testing:** Have you written and run sufficient tests for validating the changes?
- [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [X] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
This PR fixed the issue of regex exception for Safari before 16.4 (iOS 16.4), where regex lookbehind syntax is not supported. Before this change, devices that are not supported by or updated to iOS 16.4 or later are unable to use Open WebUI chat, e.g. iPhone 7.
### Fixed
- RegExp "invalid group specifier name" exception on Safari < 16.4 (#3306, #3371)
---
### Additional Information
This issue was first observed in Open WebUI 0.3.5.
For more information, see discussion here: https://github.com/open-webui/open-webui/discussions/3372#discussioncomment-9889979
Prior art:
- https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group
- https://stackoverflow.com/questions/11761563/javascript-regexp-for-splitting-text-into-sentences-and-keeping-the-delimiter
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/3564
Author: @wanderingmeow
Created: 7/1/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @tjbck
Base:
dev← Head:fix-regexp-safari-before-16.4📝 Commits (1)
de3d490fix: RegExp "invalid group specifier name" exception on Safari < 16.4 (#3306, #3371)📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/lib/utils/index.ts(+1 -1)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
This PR fixed the issue of regex exception for Safari before 16.4 (iOS 16.4), where regex lookbehind syntax is not supported. Before this change, devices that are not supported by or updated to iOS 16.4 or later are unable to use Open WebUI chat, e.g. iPhone 7.
Fixed
Additional Information
This issue was first observed in Open WebUI 0.3.5.
For more information, see discussion here: https://github.com/open-webui/open-webui/discussions/3372#discussioncomment-9889979
Prior art:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.