[PR #23628] [CLOSED] fix: enforce ownership and access grant checks on model import #50335

New Issue

GiteaMirror · 2026-04-30T03:00:11-05:00

GiteaMirror commented

2026-04-30 03:00:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23628
Author: @Classic298
Created: 4/12/2026
Status: ❌ Closed

Base: dev ← Head: fix/model-import-ownership-check

📝 Commits (3)

af51217 fix: enforce ownership and access grant checks on model import
3696e86 merge: resolve conflicts with upstream async DB migration
55ed331 fix: add missing await on filter_allowed_access_grants in import_models

📊 Changes

1 file changed (+48 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/models.py (+48 -1)

📄 Description

The model import endpoint allowed any user with workspace.models_import permission to overwrite existing models without verifying ownership or write access, and without filtering access grants through filter_allowed_access_grants.

Now enforces the same ownership/write-access check used by update_model_by_id, and applies filter_allowed_access_grants to both new and updated models during import.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23628 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/model-import-ownership-check` --- ### 📝 Commits (3) - [`af51217`](https://github.com/open-webui/open-webui/commit/af51217b81328fa6d208f5dbcb2dfefd918f0914) fix: enforce ownership and access grant checks on model import - [`3696e86`](https://github.com/open-webui/open-webui/commit/3696e86729761d5b0ef6d387796dca79242cad07) merge: resolve conflicts with upstream async DB migration - [`55ed331`](https://github.com/open-webui/open-webui/commit/55ed331f4deeb4350d58e6a06a9820048c331cc3) fix: add missing await on filter_allowed_access_grants in import_models ### 📊 Changes **1 file changed** (+48 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/models.py` (+48 -1) </details> ### 📄 Description The model import endpoint allowed any user with workspace.models_import permission to overwrite existing models without verifying ownership or write access, and without filtering access grants through filter_allowed_access_grants. Now enforces the same ownership/write-access check used by update_model_by_id, and applies filter_allowed_access_grants to both new and updated models during import. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 03:00:11 -05:00

GiteaMirror closed this issue

2026-04-30 03:00:19 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#50335