[PR #14881] [CLOSED] Feat: remove outline-hidden, due to accessibility and visibility in the tab… #23628

New Issue

GiteaMirror · 2026-04-20T04:56:02-05:00

GiteaMirror commented

2026-04-20 04:56:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14881
Author: @sinejespersen
Created: 6/11/2025
Status: ❌ Closed

Base: dev ← Head: feature/add-outline-on-focus

📝 Commits (1)

ed16285 remove outline-hidden, due to accessibility and visibility in the tab focus order

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/General.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Remove tw-class outline-hiddento make the focus order visible (accessibility)

Added

N/A

Changed

N/A

Deprecated

N/A

Removed

Remove tw-class outline-hiddento make the focus order visible (accessibility)

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

The yellow color is decided by my personal preferences in my settings

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14881 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/11/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feature/add-outline-on-focus` --- ### 📝 Commits (1) - [`ed16285`](https://github.com/open-webui/open-webui/commit/ed16285e8fa6af32fc216c467c32e4853b229990) remove outline-hidden, due to accessibility and visibility in the tab focus order ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/General.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Remove tw-class `outline-hidden`to make the focus order visible (accessibility) ### Added N/A ### Changed N/A ### Deprecated N/A ### Removed - Remove tw-class `outline-hidden`to make the focus order visible (accessibility) - ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos **The yellow color is decided by my personal preferences in my settings** <img width="914" alt="Screenshot 2025-06-11 at 11 28 37" src="https://github.com/user-attachments/assets/492118ea-f48c-4a54-95fc-7de4b4d0c006" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:56:02 -05:00

GiteaMirror closed this issue

2026-04-20 04:56:03 -05:00

GiteaMirror referenced this issue

2026-04-20 06:58:56 -05:00

[PR #23628] [CLOSED] fix: enforce ownership and access grant checks on model import #27287

GiteaMirror referenced this issue

2026-04-25 14:41:03 -05:00

[PR #23628] [CLOSED] fix: enforce ownership and access grant checks on model import #42917

GiteaMirror referenced this issue

2026-04-30 03:00:12 -05:00

[PR #23628] [CLOSED] fix: enforce ownership and access grant checks on model import #50335