github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 19:38:46 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #23455] fix: handle orphan messages in chat history to prevent UI deadlock #50252

New Issue
Open
opened 2026-04-30 02:53:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 02:53:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23455
Author: @weyseing
Created: 4/6/2026
Status: 🔄 Open

Base: dev ← Head: fix/orphan-message-deadlock

📝 Commits (1)

  • eae3d57 fix: handle orphan messages in chat history to prevent UI deadlock

📊 Changes

1 file changed (+29 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Messages.svelte (+29 -2)

📄 Description

Summary

  • Orphan messages (missing id, role, or parentId) in history.messages cause the UI to hang forever on a loading spinner when opening the chat
  • No errors in console, no crash — just a silent deadlock
  • The fix makes the frontend resilient to malformed chat data

Root Cause

Three issues in src/lib/components/chat/Messages.svelte:

  1. Infinite spinner — The "load more" check messages.at(0)?.parentId !== null uses strict equality. Orphan messages with missing parentId (undefined) pass this check (undefined !== null is true), showing the loader forever.

  2. Broken tree traversal — Same strict !== null check in buildMessages() when walking the parent chain.

  3. Blank page — When currentId points to an orphan, buildMessages() can only reach the orphan (no parent chain to valid messages), rendering nothing useful.

Fix

Change Line Description
Loose null check in template 481 !== null → != null so undefined and null both mean "root message"
Loose null check in traversal 94 Same fix in buildMessages() parent chain walk
Fallback for invalid currentId 80-112 New findLastValidMessageId() — when currentId points to invalid message, scan for the latest valid one and switch to it

Steps to Reproduce (before fix)

  1. Import a chat with a malformed message (orphan with no id/role/parentId in history.messages, and currentId pointing to it)
  2. Click on the imported chat
  3. Bug: UI shows loading spinner forever, chat is inaccessible
Test JSON for reproduction 
[
  {
    "id": "8a3351f4-79c1-4731-8826-d5783944b0c2",
    "user_id": "fe7bbdce-2468-4ce4-aa02-00edd8c48e76",
    "title": "Malformed Chat Test",
    "chat": {
      "id": "",
      "title": "Malformed Chat Test",
      "models": ["llama3.2:1b"],
      "params": {},
      "history": {
        "messages": {
          "msg-1": {
            "id": "msg-1", "parentId": null, "childrenIds": ["msg-2"],
            "role": "user", "content": "What is Python?", "timestamp": 1750304001
          },
          "msg-2": {
            "id": "msg-2", "parentId": "msg-1", "childrenIds": [],
            "role": "assistant", "content": "Python is a programming language.",
            "model": "llama3.2:1b", "timestamp": 1750304002, "done": true
          },
          "orphan-1": {
            "model": "llama3.2:1b",
            "content": "Orphan message - no id, no role, no parentId"
          }
        },
        "currentId": "orphan-1"
      },
      "messages": [
        { "id": "msg-1", "parentId": null, "childrenIds": ["msg-2"], "role": "user", "content": "What is Python?", "timestamp": 1750304001 },
        { "id": "msg-2", "parentId": "msg-1", "childrenIds": [], "role": "assistant", "content": "Python is a programming language.", "model": "llama3.2:1b", "timestamp": 1750304002, "done": true }
      ],
      "tags": [], "timestamp": 1750304001000, "files": []
    },
    "updated_at": 1750307488, "created_at": 1750304001,
    "share_id": null, "archived": false, "pinned": false, "meta": {}, "folder_id": null
  }
]

Testing

  • Imported malformed chat with 3 orphan messages + 6 valid messages
  • Before fix: infinite loading spinner, chat inaccessible
  • After fix: orphans skipped, full conversation renders normally
  • Verified normal chats still work correctly
  • Tested with Ollama (llama3.2:1b) via Docker Compose on macOS

Fixes #15189

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23455 **Author:** [@weyseing](https://github.com/weyseing) **Created:** 4/6/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/orphan-message-deadlock` --- ### 📝 Commits (1) - [`eae3d57`](https://github.com/open-webui/open-webui/commit/eae3d576bb9d82b623e7334a10fb1f389b70f4a6) fix: handle orphan messages in chat history to prevent UI deadlock ### 📊 Changes **1 file changed** (+29 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages.svelte` (+29 -2) </details> ### 📄 Description ## Summary - Orphan messages (missing `id`, `role`, or `parentId`) in `history.messages` cause the UI to hang forever on a loading spinner when opening the chat - No errors in console, no crash — just a silent deadlock - The fix makes the frontend resilient to malformed chat data ## Root Cause Three issues in `src/lib/components/chat/Messages.svelte`: 1. **Infinite spinner** — The "load more" check `messages.at(0)?.parentId !== null` uses strict equality. Orphan messages with missing `parentId` (`undefined`) pass this check (`undefined !== null` is `true`), showing the loader forever. 2. **Broken tree traversal** — Same strict `!== null` check in `buildMessages()` when walking the parent chain. 3. **Blank page** — When `currentId` points to an orphan, `buildMessages()` can only reach the orphan (no parent chain to valid messages), rendering nothing useful. ## Fix | Change | Line | Description | |--------|------|-------------| | Loose null check in template | 481 | `!== null` → `!= null` so `undefined` and `null` both mean "root message" | | Loose null check in traversal | 94 | Same fix in `buildMessages()` parent chain walk | | Fallback for invalid `currentId` | 80-112 | New `findLastValidMessageId()` — when `currentId` points to invalid message, scan for the latest valid one and switch to it | ## Steps to Reproduce (before fix) 1. Import a chat with a malformed message (orphan with no `id`/`role`/`parentId` in `history.messages`, and `currentId` pointing to it) 2. Click on the imported chat 3. **Bug:** UI shows loading spinner forever, chat is inaccessible <details> <summary>Test JSON for reproduction</summary> ```json [ { "id": "8a3351f4-79c1-4731-8826-d5783944b0c2", "user_id": "fe7bbdce-2468-4ce4-aa02-00edd8c48e76", "title": "Malformed Chat Test", "chat": { "id": "", "title": "Malformed Chat Test", "models": ["llama3.2:1b"], "params": {}, "history": { "messages": { "msg-1": { "id": "msg-1", "parentId": null, "childrenIds": ["msg-2"], "role": "user", "content": "What is Python?", "timestamp": 1750304001 }, "msg-2": { "id": "msg-2", "parentId": "msg-1", "childrenIds": [], "role": "assistant", "content": "Python is a programming language.", "model": "llama3.2:1b", "timestamp": 1750304002, "done": true }, "orphan-1": { "model": "llama3.2:1b", "content": "Orphan message - no id, no role, no parentId" } }, "currentId": "orphan-1" }, "messages": [ { "id": "msg-1", "parentId": null, "childrenIds": ["msg-2"], "role": "user", "content": "What is Python?", "timestamp": 1750304001 }, { "id": "msg-2", "parentId": "msg-1", "childrenIds": [], "role": "assistant", "content": "Python is a programming language.", "model": "llama3.2:1b", "timestamp": 1750304002, "done": true } ], "tags": [], "timestamp": 1750304001000, "files": [] }, "updated_at": 1750307488, "created_at": 1750304001, "share_id": null, "archived": false, "pinned": false, "meta": {}, "folder_id": null } ] ``` </details> ## Testing - Imported malformed chat with 3 orphan messages + 6 valid messages - Before fix: infinite loading spinner, chat inaccessible - After fix: orphans skipped, full conversation renders normally - Verified normal chats still work correctly - Tested with Ollama (llama3.2:1b) via Docker Compose on macOS Fixes #15189 --- - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 02:53:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#50252
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?