[PR #14373] [CLOSED] fix: improve performance by loading function modules in get_all_models #23455

New Issue

GiteaMirror · 2026-04-20T04:50:11-05:00

GiteaMirror commented

2026-04-20 04:50:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14373
Author: @hurxxxx
Created: 5/27/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

c3ae5ad improve performance by preloading unique function modules in get_all_models

📊 Changes

1 file changed (+22 additions, -0 deletions)

View changed files

📝 backend/open_webui/utils/models.py (+22 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Improved get_all_models() performance by eliminating redundant function module loading.

Changed

Collect and reload unique function IDs once upfront
Added reload_function_module_by_id() for forced reload
Added get_function_module_by_id() to reuse cached modules

Screenshots or Videos

Before
After

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14373 **Author:** [@hurxxxx](https://github.com/hurxxxx) **Created:** 5/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`c3ae5ad`](https://github.com/open-webui/open-webui/commit/c3ae5ad1df78ccdb4f0a22b9a88932d0c71c394d) improve performance by preloading unique function modules in get_all_models ### 📊 Changes **1 file changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/models.py` (+22 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Improved get_all_models() performance by eliminating redundant function module loading. ### Changed - Collect and reload unique function IDs once upfront - Added reload_function_module_by_id() for forced reload - Added get_function_module_by_id() to reuse cached modules ### Screenshots or Videos - Before ![스크린샷 2025-05-27 120057](https://github.com/user-attachments/assets/e73e6243-c5b4-4e20-98c1-a056f36cd0f7) - After ![스크린샷 2025-05-27 131740](https://github.com/user-attachments/assets/f78d9a11-ca6d-41c0-ac8d-0eeecb64709d) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:50:11 -05:00

GiteaMirror closed this issue

2026-04-20 04:50:12 -05:00

GiteaMirror referenced this issue

2026-04-20 06:55:57 -05:00

[PR #23455] fix: handle orphan messages in chat history to prevent UI deadlock #27204

GiteaMirror referenced this issue

2026-04-25 14:37:25 -05:00

[PR #23455] fix: handle orphan messages in chat history to prevent UI deadlock #42834

GiteaMirror referenced this issue

2026-04-30 02:53:07 -05:00

[PR #23455] fix: handle orphan messages in chat history to prevent UI deadlock #50252