[PR #20686] [CLOSED] Fix SCIM Groups endpoint: Implement missing filter parameter support - Fix for #17981 #48775

New Issue

GiteaMirror · 2026-04-30T00:50:08-05:00

GiteaMirror commented

2026-04-30 00:50:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20686
Author: @iTzxToast
Created: 1/15/2026
Status: ❌ Closed

Base: main ← Head: dev

📝 Commits (10+)

b464b48 Merge pull request #20581 from Classic298/fix/db-pool-memory-update
3fc8661 fix(db): CRITICAL - prevent pool exhaustion in memory /reset (#20580)
182d5e8 fix(db): release connection before embedding in process_files_batch (#20576)
826e9ab fix(db): release connection before embeddings in knowledge /metadata/reindex (#20577)
2426257 fix(db): release connection before embedding in memory /add (#20578)
d0c2bfd fix(db): release connection before LLM call in OpenAI /chat/completions (#20572)
0b5aa6d fix(db): release connection before LLM call in Ollama /api/chat (#20571)
2faab40 i18n(pl-PL): Add missing keys and update existing translations (#20562)
84263fc i18n: Updated the Catalan translation file (#20566)
24044b4 fix(db): release connection before LLM call in Ollama /v1/chat/completions (#20569)

📊 Changes

23 files changed (+735 additions, -522 deletions)

View changed files

📝 backend/open_webui/models/groups.py (+7 -6)
📝 backend/open_webui/retrieval/loaders/main.py (+1 -1)
📝 backend/open_webui/routers/channels.py (+2 -6)
📝 backend/open_webui/routers/knowledge.py (+22 -13)
📝 backend/open_webui/routers/memories.py (+24 -8)
📝 backend/open_webui/routers/models.py (+2 -4)
📝 backend/open_webui/routers/ollama.py (+15 -9)
📝 backend/open_webui/routers/openai.py (+5 -3)
📝 backend/open_webui/routers/retrieval.py (+6 -2)
📝 backend/open_webui/routers/users.py (+2 -4)
📝 backend/open_webui/tools/builtin.py (+161 -1)
📝 backend/open_webui/utils/tools.py (+11 -0)
📝 src/lib/components/chat/Chat.svelte (+5 -0)
📝 src/lib/components/workspace/common/AccessControl.svelte (+4 -1)
📝 src/lib/components/workspace/common/MemberSelector.svelte (+5 -1)
📝 src/lib/i18n/locales/ca-ES/translation.json (+115 -115)
📝 src/lib/i18n/locales/de-DE/translation.json (+9 -9)
📝 src/lib/i18n/locales/es-ES/translation.json (+87 -87)
📝 src/lib/i18n/locales/ja-JP/translation.json (+25 -25)
📝 src/lib/i18n/locales/pl-PL/translation.json (+186 -186)

...and 3 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

[Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

[List any fixes, corrections, or bug fixes]

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20686 **Author:** [@iTzxToast](https://github.com/iTzxToast) **Created:** 1/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (10+) - [`b464b48`](https://github.com/open-webui/open-webui/commit/b464b48f53e6eda17813d684909254819ac599e3) Merge pull request #20581 from Classic298/fix/db-pool-memory-update - [`3fc8661`](https://github.com/open-webui/open-webui/commit/3fc866117da65c4a3e05e1a2add40b193933fd97) fix(db): CRITICAL - prevent pool exhaustion in memory /reset (#20580) - [`182d5e8`](https://github.com/open-webui/open-webui/commit/182d5e8591560dcc5a58f49068f91ad46c605952) fix(db): release connection before embedding in process_files_batch (#20576) - [`826e9ab`](https://github.com/open-webui/open-webui/commit/826e9ab317d5376c6eeb93870481dad3bf99ae96) fix(db): release connection before embeddings in knowledge /metadata/reindex (#20577) - [`2426257`](https://github.com/open-webui/open-webui/commit/242625782f03a2ee9c529b4df69a9d55481e6854) fix(db): release connection before embedding in memory /add (#20578) - [`d0c2bfd`](https://github.com/open-webui/open-webui/commit/d0c2bfdbff2b12e8190379cef8f442b1cf210470) fix(db): release connection before LLM call in OpenAI /chat/completions (#20572) - [`0b5aa6d`](https://github.com/open-webui/open-webui/commit/0b5aa6dd60c5502ad98a0bea903142763a1e3f91) fix(db): release connection before LLM call in Ollama /api/chat (#20571) - [`2faab40`](https://github.com/open-webui/open-webui/commit/2faab409d346a7abf88c9085b44e6bc73f2a14a0) i18n(pl-PL): Add missing keys and update existing translations (#20562) - [`84263fc`](https://github.com/open-webui/open-webui/commit/84263fc6a6435226e6a2ac29b421b41fad632067) i18n: Updated the Catalan translation file (#20566) - [`24044b4`](https://github.com/open-webui/open-webui/commit/24044b42ea97f8fd855472b2c0abc497a813843b) fix(db): release connection before LLM call in Ollama /v1/chat/completions (#20569) ### 📊 Changes **23 files changed** (+735 additions, -522 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/groups.py` (+7 -6) 📝 `backend/open_webui/retrieval/loaders/main.py` (+1 -1) 📝 `backend/open_webui/routers/channels.py` (+2 -6) 📝 `backend/open_webui/routers/knowledge.py` (+22 -13) 📝 `backend/open_webui/routers/memories.py` (+24 -8) 📝 `backend/open_webui/routers/models.py` (+2 -4) 📝 `backend/open_webui/routers/ollama.py` (+15 -9) 📝 `backend/open_webui/routers/openai.py` (+5 -3) 📝 `backend/open_webui/routers/retrieval.py` (+6 -2) 📝 `backend/open_webui/routers/users.py` (+2 -4) 📝 `backend/open_webui/tools/builtin.py` (+161 -1) 📝 `backend/open_webui/utils/tools.py` (+11 -0) 📝 `src/lib/components/chat/Chat.svelte` (+5 -0) 📝 `src/lib/components/workspace/common/AccessControl.svelte` (+4 -1) 📝 `src/lib/components/workspace/common/MemberSelector.svelte` (+5 -1) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+115 -115) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+9 -9) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+87 -87) 📝 `src/lib/i18n/locales/ja-JP/translation.json` (+25 -25) 📝 `src/lib/i18n/locales/pl-PL/translation.json` (+186 -186) _...and 3 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [ ] **Description:** Provide a concise description of the changes made in this pull request down below. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [ ] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)] ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-30 00:50:08 -05:00

GiteaMirror closed this issue

2026-04-30 00:50:14 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#48775