[PR #20814] [CLOSED] fix: Hide dropdown options for tools/functions with empty Uservalves #41424

New Issue

GiteaMirror · 2026-04-25T13:40:35-05:00

GiteaMirror commented

2026-04-25 13:40:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20814
Author: @silentoplayz
Created: 1/20/2026
Status: ❌ Closed

Base: dev ← Head: fix/hide-empty-valves

📝 Commits (1)

cb40141 ix: hide dropdown options for tools/functions with empty Valves

📊 Changes

3 files changed (+131 additions, -4 deletions)

View changed files

📝 backend/open_webui/models/functions.py (+127 -2)
📝 backend/open_webui/routers/tools.py (+2 -0)
📝 src/lib/components/chat/Controls/Valves.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This fix hides the Chat Controls dropdown options for tools/functions that have empty Valves or UserValves classes (containing only pass or docstrings). This improves UX by not showing configuration options when there are no actual fields to configure.

Added

_has_configurable_valves() static method in FunctionsTable to detect if a function's Valves class has actual configurable fields
_has_configurable_user_valves() static method in FunctionsTable to detect if a function's UserValves class has actual configurable fields
has_valves field to FunctionResponse and FunctionUserResponse models
has_user_valves field to FunctionResponse and FunctionUserResponse models
has_user_valves: False for OpenAPI and MCP tool servers

Changed

get_functions() in FunctionsTable now returns FunctionResponse with has_valves and has_user_valves fields populated
Chat Controls Valves.svelte dropdowns now filter to show only tools/functions with configurable UserValves

Fixed

Empty Valves classes (only pass or docstrings) no longer show gear icons or appear in dropdowns
Handles edge cases: single-line docstrings, multi-line docstrings, methods after empty Valves class

Additional Information

Related to PR work done at https://github.com/open-webui/open-webui/pull/20810 and https://github.com/open-webui/open-webui/pull/20691
The detection logic parses Python source to find class Valves(BaseModel): or class UserValves(BaseModel): and checks for actual field definitions (lines containing : that aren't def/class/decorator/method definitions)

Before - Shows all tools and functions, regardless if it has configurable Uservalves or not

After - Respects whether or not the tool or function has Uservalves and filters out tools and functions that doesn't have any configurable Uservalves

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20814 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 1/20/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/hide-empty-valves` --- ### 📝 Commits (1) - [`cb40141`](https://github.com/open-webui/open-webui/commit/cb40141b7471bfb928c1a53a4db23059b7edfd47) ix: hide dropdown options for tools/functions with empty Valves ### 📊 Changes **3 files changed** (+131 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/functions.py` (+127 -2) 📝 `backend/open_webui/routers/tools.py` (+2 -0) 📝 `src/lib/components/chat/Controls/Valves.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This fix hides the Chat Controls dropdown options for tools/functions that have empty `Valves` or `UserValves` classes (containing only `pass` or docstrings). This improves UX by not showing configuration options when there are no actual fields to configure. ### Added - `_has_configurable_valves()` static method in `FunctionsTable` to detect if a function's Valves class has actual configurable fields - `_has_configurable_user_valves()` static method in `FunctionsTable` to detect if a function's UserValves class has actual configurable fields - `has_valves` field to `FunctionResponse` and `FunctionUserResponse` models - `has_user_valves` field to `FunctionResponse` and `FunctionUserResponse` models - `has_user_valves: False` for OpenAPI and MCP tool servers ### Changed - `get_functions()` in `FunctionsTable` now returns `FunctionResponse` with `has_valves` and `has_user_valves` fields populated - Chat Controls `Valves.svelte` dropdowns now filter to show only tools/functions with configurable UserValves ### Fixed - Empty Valves classes (only `pass` or docstrings) no longer show gear icons or appear in dropdowns - Handles edge cases: single-line docstrings, multi-line docstrings, methods after empty Valves class --- ### Additional Information - Related to PR work done at https://github.com/open-webui/open-webui/pull/20810 and https://github.com/open-webui/open-webui/pull/20691 - The detection logic parses Python source to find class `Valves(BaseModel):` or class `UserValves(BaseModel):` and checks for actual field definitions (lines containing `:` that aren't def/class/decorator/method definitions) ### Before - Shows all tools and functions, regardless if it has configurable Uservalves or not <img width="350" height="1280" alt="image" src="https://github.com/user-attachments/assets/57706782-3a30-445e-b99a-9d62962ddad6" /> <img width="350" height="1280" alt="image" src="https://github.com/user-attachments/assets/d56fffe1-3492-482c-8dc3-20e5bea92969" /> ### After - Respects whether or not the tool or function has Uservalves and filters out tools and functions that doesn't have any configurable Uservalves <img width="350" height="1280" alt="image" src="https://github.com/user-attachments/assets/3e13067e-5366-4382-86cb-9be6ad9daf9a" /> <img width="350" height="1280" alt="image" src="https://github.com/user-attachments/assets/039e3cec-4397-4d87-b537-1c323330a9f9" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:40:35 -05:00

GiteaMirror closed this issue

2026-04-25 13:40:38 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41424