d4339fe fix: modal should not close when dragging from inside of modal
📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝src/lib/components/common/Modal.svelte (+2 -2)
📄 Description
Description
Closes#1852.
Use mousedown event instead of click event to prevent modal window from closing on mouseup unexpectedly.
Fixed
Settings modal should not close when dragging from inside of modal
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/1853
**Author:** [@domsleee](https://github.com/domsleee)
**Created:** 4/29/2024
**Status:** ✅ Merged
**Merged:** 4/29/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix/modal-closing-on-mouseup`
---
### 📝 Commits (1)
- [`d4339fe`](https://github.com/open-webui/open-webui/commit/d4339fe769c9f990a9d0b28af47fc2eb06b50296) fix: modal should not close when dragging from inside of modal
### 📊 Changes
**1 file changed** (+2 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/common/Modal.svelte` (+2 -2)
</details>
### 📄 Description
## Description
Closes #1852.
Use `mousedown` event instead of `click` event to prevent modal window from closing on `mouseup` unexpectedly.
---
### Fixed
- Settings modal should not close when dragging from inside of modal
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/1853
Author: @domsleee
Created: 4/29/2024
Status: ✅ Merged
Merged: 4/29/2024
Merged by: @tjbck
Base:
dev← Head:fix/modal-closing-on-mouseup📝 Commits (1)
d4339fefix: modal should not close when dragging from inside of modal📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
src/lib/components/common/Modal.svelte(+2 -2)📄 Description
Description
Closes #1852.
Use
mousedownevent instead ofclickevent to prevent modal window from closing onmouseupunexpectedly.Fixed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.