[PR #19492] [CLOSED] fix: MCP function_name_filter_list type handling #40860

New Issue

GiteaMirror · 2026-04-25T13:15:40-05:00

GiteaMirror commented

2026-04-25 13:15:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19492
Author: @kathrynalpert
Created: 11/25/2025
Status: ❌ Closed

Base: dev ← Head: fix-19486

📝 Commits (1)

4ea3479 fix: MCP function_name_filter_list type handling

📊 Changes

3 files changed (+17 additions, -9 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+7 -3)
📝 backend/open_webui/utils/tools.py (+7 -3)
📝 src/lib/components/AddToolServerModal.svelte (+3 -3)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fix MCP tool server loading failure when function_name_filter_list is empty, which caused 'list' object has no attribute 'split' error #19486

Fixed

MCP tool servers can now be added with an empty "Function Name Filter List" without triggering AttributeError
- Backend now handles both list (for backward compatibility) and string types for function_name_filter_list in middleware.py and tools.py
- Frontend initializes functionNameFilterList as empty string instead of empty array in AddToolServerModal.svelte

Note for reviewers

If backward compatibility is not a concern (assuming no one left this field as a list, since that wouldn't work due to this bug), we can remove the changes to the backend code.
Alternatively, I'd be happy to DRY this out into a shared backend function if desired; I've proceeded with the current code to best match the original implementation.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19492 **Author:** [@kathrynalpert](https://github.com/kathrynalpert) **Created:** 11/25/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-19486` --- ### 📝 Commits (1) - [`4ea3479`](https://github.com/open-webui/open-webui/commit/4ea3479a713696ad93f8d03841a39d36e520480d) fix: MCP function_name_filter_list type handling ### 📊 Changes **3 files changed** (+17 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+7 -3) 📝 `backend/open_webui/utils/tools.py` (+7 -3) 📝 `src/lib/components/AddToolServerModal.svelte` (+3 -3) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Fix MCP tool server loading failure when function_name_filter_list is empty, which caused `'list' object has no attribute 'split'` error #19486 ### Fixed - MCP tool servers can now be added with an empty "Function Name Filter List" without triggering AttributeError - Backend now handles both list (for backward compatibility) and string types for `function_name_filter_list` in `middleware.py` and `tools.py` - Frontend initializes `functionNameFilterList` as empty string instead of empty array in `AddToolServerModal.svelte` #### Note for reviewers - If backward compatibility is not a concern (assuming no one left this field as a list, since that wouldn't work due to this bug), we can remove the changes to the backend code. - Alternatively, I'd be happy to DRY this out into a shared backend function if desired; I've proceeded with the current code to best match the original implementation. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:15:40 -05:00

GiteaMirror closed this issue

2026-04-25 13:15:40 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#40860