Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Change interactive elements in <DropdownMenu to <DropdownItems from bits-ui
TABBING BEFORE (double tab on nested button and elements in the dom unreachable by keyboard):
TABBING AFTER:
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/15477
**Author:** [@sinejespersen](https://github.com/sinejespersen)
**Created:** 7/2/2025
**Status:** ✅ Merged
**Merged:** 7/2/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `feature/accessibility-user-settings`
---
### 📝 Commits (3)
- [`7e49c87`](https://github.com/open-webui/open-webui/commit/7e49c8733bf02de5e0a118af48b7ab94f7a49380) remove nested button and add label for assistive technology
- [`b725585`](https://github.com/open-webui/open-webui/commit/b7255854d2b39c072df63087da6f97734ae1cf76) change interactive elements in dropdownmenu to dropdownitems
- [`225d20f`](https://github.com/open-webui/open-webui/commit/225d20fb84029148d5817a257caf8b82c0a9d02e) aria hidden on decorative svgs to enhance accessibility
### 📊 Changes
**9 files changed** (+23 additions, -20 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/chat/Navbar.svelte` (+4 -4)
📝 `src/lib/components/icons/ArchiveBox.svelte` (+1 -0)
📝 `src/lib/components/icons/Code.svelte` (+1 -0)
📝 `src/lib/components/icons/Map.svelte` (+1 -0)
📝 `src/lib/components/icons/QuestionMarkCircle.svelte` (+1 -0)
📝 `src/lib/components/icons/Settings.svelte` (+1 -0)
📝 `src/lib/components/icons/SignOut.svelte` (+1 -0)
📝 `src/lib/components/icons/UserGroup.svelte` (+1 -0)
📝 `src/lib/components/layout/Sidebar/UserMenu.svelte` (+12 -16)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
https://github.com/open-webui/open-webui/discussions/8908
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Change interactive elements in `<DropdownMenu` to `<DropdownItems` from `bits-ui`
- `aria-hidden` on decorative element
- Remove nested button as a button [there must be no interactive content descendant and no descendant with the tabindex attribute specified.](https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element)
### Added
- Add margin to make outline visible
- Add outline on high contrast mode
- `aria-hidden` on decorative element
### Changed
- Change interactive elements in `<DropdownMenu` to `<DropdownItems` from `bits-ui`
- Remove nested button as a button [there must be no interactive content descendant and no descendant with the tabindex attribute specified.](https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element)
### Removed
N/A
### Fixed
N/A
### Security
N/A
### Breaking Changes
N/A
---
### Additional Information
N/A
### Screenshots or Videos
**TABBING BEFORE** (double tab on nested button and elements in the dom unreachable by keyboard):
**TABBING AFTER**:
### Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/15477
Author: @sinejespersen
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @tjbck
Base:
dev← Head:feature/accessibility-user-settings📝 Commits (3)
7e49c87remove nested button and add label for assistive technologyb725585change interactive elements in dropdownmenu to dropdownitems225d20faria hidden on decorative svgs to enhance accessibility📊 Changes
9 files changed (+23 additions, -20 deletions)
View changed files
📝
src/lib/components/chat/Navbar.svelte(+4 -4)📝
src/lib/components/icons/ArchiveBox.svelte(+1 -0)📝
src/lib/components/icons/Code.svelte(+1 -0)📝
src/lib/components/icons/Map.svelte(+1 -0)📝
src/lib/components/icons/QuestionMarkCircle.svelte(+1 -0)📝
src/lib/components/icons/Settings.svelte(+1 -0)📝
src/lib/components/icons/SignOut.svelte(+1 -0)📝
src/lib/components/icons/UserGroup.svelte(+1 -0)📝
src/lib/components/layout/Sidebar/UserMenu.svelte(+12 -16)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
https://github.com/open-webui/open-webui/discussions/8908
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
<DropdownMenuto<DropdownItemsfrombits-uiaria-hiddenon decorative elementAdded
aria-hiddenon decorative elementChanged
<DropdownMenuto<DropdownItemsfrombits-uiRemoved
N/A
Fixed
N/A
Security
N/A
Breaking Changes
N/A
Additional Information
N/A
Screenshots or Videos
TABBING BEFORE (double tab on nested button and elements in the dom unreachable by keyboard):
TABBING AFTER:
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.