github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 19:08:59 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #14753] [CLOSED] feat: toggle to delete chats in folder #23578

New Issue
Closed
opened 2026-04-20 04:54:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 04:54:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14753
Author: @expruc
Created: 6/7/2025
Status: ❌ Closed

Base: dev ← Head: feat/folder_dont_delete_chats

📝 Commits (5)

📊 Changes

57 files changed (+213 additions, -63 deletions)

View changed files

📝 backend/open_webui/models/chats.py (+5 -0)
📝 backend/open_webui/models/folders.py (+18 -1)
📝 backend/open_webui/routers/folders.py (+6 -1)
📝 src/lib/apis/folders/index.ts (+5 -2)
📝 src/lib/components/layout/Sidebar/RecursiveFolder.svelte (+23 -7)
📝 src/lib/i18n/locales/ar-BH/translation.json (+3 -1)
📝 src/lib/i18n/locales/ar/translation.json (+3 -1)
📝 src/lib/i18n/locales/bg-BG/translation.json (+3 -1)
📝 src/lib/i18n/locales/bn-BD/translation.json (+3 -1)
📝 src/lib/i18n/locales/bo-TB/translation.json (+3 -1)
📝 src/lib/i18n/locales/ca-ES/translation.json (+3 -1)
📝 src/lib/i18n/locales/ceb-PH/translation.json (+3 -1)
📝 src/lib/i18n/locales/cs-CZ/translation.json (+3 -1)
📝 src/lib/i18n/locales/da-DK/translation.json (+3 -1)
📝 src/lib/i18n/locales/de-DE/translation.json (+3 -1)
📝 src/lib/i18n/locales/dg-DG/translation.json (+3 -1)
📝 src/lib/i18n/locales/el-GR/translation.json (+3 -1)
📝 src/lib/i18n/locales/en-GB/translation.json (+3 -1)
📝 src/lib/i18n/locales/en-US/translation.json (+3 -1)
📝 src/lib/i18n/locales/es-ES/translation.json (+3 -1)

...and 37 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When deleting a folder, instead of deleting the chats in said folder automatically I have added a button to toggle chat deletion. If user chooses to not delete chats the chats are moved back to the default chats folder (where new chats are placed).

Added

  • Checkbox to toggle chat deletion for chats in folder when deleting a folder. Screenshot provided below

Additional Information

This is to mitigate #14578. If user chooses to keep chats both archived and non-archived chats are not deleted.

I have used the existing flag delete_chats in the delete_folder_by_id_and_user_id function, and added functionality to find all the chats in a directory and move them to default chats folder (folder with null id).

Screenshots or Videos

image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14753 **Author:** [@expruc](https://github.com/expruc) **Created:** 6/7/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/folder_dont_delete_chats` --- ### 📝 Commits (5) - [`db91439`](https://github.com/open-webui/open-webui/commit/db91439411796ca76fd95767639cbd9c8e9644ef) feat: add toggle to delete chats on folder deletion - [`36c9024`](https://github.com/open-webui/open-webui/commit/36c902438cd94ec695d151208081289682e50a27) cleanup - [`b19cc8e`](https://github.com/open-webui/open-webui/commit/b19cc8e9b91b218eb3ac7771d12e23cee0f0b6e6) ci issues: fix - [`20e9e8e`](https://github.com/open-webui/open-webui/commit/20e9e8ebb5a08e96e2fb6fb0ffed4dc6646d35a0) ci issues: fix - [`6db2e8a`](https://github.com/open-webui/open-webui/commit/6db2e8a66fd59354349e237c5afe6b544441e00c) ci issues: black-linting ### 📊 Changes **57 files changed** (+213 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/chats.py` (+5 -0) 📝 `backend/open_webui/models/folders.py` (+18 -1) 📝 `backend/open_webui/routers/folders.py` (+6 -1) 📝 `src/lib/apis/folders/index.ts` (+5 -2) 📝 `src/lib/components/layout/Sidebar/RecursiveFolder.svelte` (+23 -7) 📝 `src/lib/i18n/locales/ar-BH/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ar/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bg-BG/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bn-BD/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bo-TB/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ceb-PH/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/cs-CZ/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/da-DK/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/dg-DG/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/el-GR/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/en-GB/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/en-US/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+3 -1) _...and 37 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description When deleting a folder, instead of deleting the chats in said folder automatically I have added a button to toggle chat deletion. If user chooses to not delete chats the chats are moved back to the default chats folder (where new chats are placed). ### Added - Checkbox to toggle chat deletion for chats in folder when deleting a folder. Screenshot provided below --- ### Additional Information This is to mitigate #14578. If user chooses to keep chats both archived and non-archived chats are not deleted. I have used the existing flag `delete_chats` in the `delete_folder_by_id_and_user_id` function, and added functionality to find all the chats in a directory and move them to default chats folder (folder with null id). ### Screenshots or Videos ![image](https://github.com/user-attachments/assets/b3d58ad3-d453-4e5a-83dc-acae7097148f) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:54:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?