[PR #524] [MERGED] subprocess improvements #72491

Closed
opened 2026-05-05 04:01:42 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/524
Author: @BruceMacD
Created: 9/13/2023
Status: Merged
Merged: 9/18/2023
Merged by: @BruceMacD

Base: mainHead: brucemacd/subprocess-check-running


📝 Commits (4)

📊 Changes

4 files changed (+120 additions, -105 deletions)

View changed files

📝 llm/ggml.go (+5 -5)
📝 llm/gguf.go (+5 -5)
📝 llm/llama.cpp/generate_darwin_arm64.go (+4 -4)
📝 llm/llama.go (+106 -91)

📄 Description

  • increase start-up timeout
  • when runner fails to start fail rather than timing out
  • try runners in order rather than choosing 1 runner
  • embed metal runner in metal dir rather than gpu
  • refactor logging and error messages

resolves #485


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/524 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 9/13/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/subprocess-check-running` --- ### 📝 Commits (4) - [`3518d79`](https://github.com/ollama/ollama/commit/3518d79c5d5757b03770e7237e66cda857ceb5fb) subprocess improvements - [`5f507b9`](https://github.com/ollama/ollama/commit/5f507b92af40f8a0b93f80cfe49d5ff9075dcf95) Update llama.go - [`8c111ce`](https://github.com/ollama/ollama/commit/8c111ce539402305fa562270cffa52c92a5b258d) Update llama.go - [`7621659`](https://github.com/ollama/ollama/commit/762165979eaa970d0b6b6f2c4969bc492d97bf42) simplify by using glob ### 📊 Changes **4 files changed** (+120 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `llm/ggml.go` (+5 -5) 📝 `llm/gguf.go` (+5 -5) 📝 `llm/llama.cpp/generate_darwin_arm64.go` (+4 -4) 📝 `llm/llama.go` (+106 -91) </details> ### 📄 Description - increase start-up timeout - when runner fails to start fail rather than timing out - try runners in order rather than choosing 1 runner - embed metal runner in metal dir rather than gpu - refactor logging and error messages resolves #485 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 04:01:42 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#72491