github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15443] [MERGED] mlx: remove stale x86 libmlx library #25699

New Issue
Closed
opened 2026-04-19 18:21:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:21:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15443
Author: @dhiltgen
Created: 4/9/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @dhiltgen

Base: main ← Head: fix-mlx-darwin-lipo

📝 Commits (1)

  • 207c7ad mlx: remove stale x86 libmlx library

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 scripts/build_darwin.sh (+6 -1)

📄 Description

Fixes #15433

The release contains an extraneous library from the old pattern of placing it at the top.

% find app -name \*mlx\*.dylib | xargs file
app/Ollama.app/Contents/Resources/libmlx.dylib:               Mach-O 64-bit dynamically linked shared library x86_64
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib:  Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64]
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64]
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64
app/Ollama.app/Contents/Resources/libmlxc.dylib:              Mach-O 64-bit dynamically linked shared library x86_64
app/Ollama.app/Contents/Resources/mlx_metal_v4/libmlx.dylib:  Mach-O 64-bit dynamically linked shared library arm64
app/Ollama.app/Contents/Resources/mlx_metal_v4/libmlxc.dylib: Mach-O 64-bit dynamically linked shared library arm64

The mlx_metal_v3 version is correctly lipo'd to support both architectures, so this top-level x86-only version was not supposed to be retained.

With this fix:

% find dist/Ollama.app -name \*mlx\*.dylib | xargs fi
le
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib:  Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64]
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64]
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64
dist/Ollama.app/Contents/Resources/mlx_metal_v4/libmlx.dylib:  Mach-O 64-bit dynamically linked shared library arm64
dist/Ollama.app/Contents/Resources/mlx_metal_v4/libmlxc.dylib: Mach-O 64-bit dynamically linked shared library arm64

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15443 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 4/9/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `fix-mlx-darwin-lipo` --- ### 📝 Commits (1) - [`207c7ad`](https://github.com/ollama/ollama/commit/207c7ad8fb1a1d7cea7201e0eaa08cf51eb25373) mlx: remove stale x86 libmlx library ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/build_darwin.sh` (+6 -1) </details> ### 📄 Description Fixes #15433 The release contains an extraneous library from the old pattern of placing it at the top. ``` % find app -name \*mlx\*.dylib | xargs file app/Ollama.app/Contents/Resources/libmlx.dylib: Mach-O 64-bit dynamically linked shared library x86_64 app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64] app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64 app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64] app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 app/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64 app/Ollama.app/Contents/Resources/libmlxc.dylib: Mach-O 64-bit dynamically linked shared library x86_64 app/Ollama.app/Contents/Resources/mlx_metal_v4/libmlx.dylib: Mach-O 64-bit dynamically linked shared library arm64 app/Ollama.app/Contents/Resources/mlx_metal_v4/libmlxc.dylib: Mach-O 64-bit dynamically linked shared library arm64 ``` The mlx_metal_v3 version is correctly lipo'd to support both architectures, so this top-level x86-only version was not supposed to be retained. With this fix: ``` % find dist/Ollama.app -name \*mlx\*.dylib | xargs fi le dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64] dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlx.dylib (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64 dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64:Mach-O 64-bit dynamically linked shared library arm64] dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 dist/Ollama.app/Contents/Resources/mlx_metal_v3/libmlxc.dylib (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64 dist/Ollama.app/Contents/Resources/mlx_metal_v4/libmlx.dylib: Mach-O 64-bit dynamically linked shared library arm64 dist/Ollama.app/Contents/Resources/mlx_metal_v4/libmlxc.dylib: Mach-O 64-bit dynamically linked shared library arm64 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:21:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?