github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #461] [MERGED] fix inherit params #15433

New Issue
Closed
opened 2026-04-16 04:59:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 04:59:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/461
Author: @mxyng
Created: 9/3/2023
Status: ✅ Merged
Merged: 9/5/2023
Merged by: @mxyng

Base: main ← Head: mxyng/fix-inherit-params

📝 Commits (2)

📊 Changes

3 files changed (+33 additions, -8 deletions)

View changed files

📝 go.mod (+1 -0)
📝 go.sum (+2 -0)
📝 server/images.go (+30 -8)

📄 Description

params from inherited models are not merged into the new model

test cases:

  • add parameters to model with no parameters:
    input:
FROM orca-mini:3b
PARAMETER temperature 0

output:

{
  "temperature": 0
}
  • no parameters with model with parameters:
    input:
FROM codellama:7b-code

output:

{
  "rope_frequency_base": 1000000
}
  • add parameters to model with parameters:
    input:
FROM codellama:7b-code
PARAMETER temperature 0

output:

{
  "rope_frequency_base": 1000000,
  "temperature": 0
}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/461 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 9/3/2023 **Status:** ✅ Merged **Merged:** 9/5/2023 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fix-inherit-params` --- ### 📝 Commits (2) - [`e9f6df7`](https://github.com/ollama/ollama/commit/e9f6df7dca85abfe473d5b74c25cb45286746483) use slices.DeleteFunc - [`06ef90c`](https://github.com/ollama/ollama/commit/06ef90c051d0637bd46d9339d6829fe4c7641cd6) fix parameter inheritence ### 📊 Changes **3 files changed** (+33 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+1 -0) 📝 `go.sum` (+2 -0) 📝 `server/images.go` (+30 -8) </details> ### 📄 Description params from inherited models are not merged into the new model test cases: - add parameters to model with no parameters: input: ``` FROM orca-mini:3b PARAMETER temperature 0 ``` output: ```json { "temperature": 0 } ``` - no parameters with model with parameters: input: ``` FROM codellama:7b-code ``` output: ```json { "rope_frequency_base": 1000000 } ``` - add parameters to model with parameters: input: ``` FROM codellama:7b-code PARAMETER temperature 0 ``` output: ```json { "rope_frequency_base": 1000000, "temperature": 0 } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 04:59:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#15433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?