github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14286] cmd: fix panic when model digest is shorter than 12 characters #14602

New Issue
Open
opened 2026-04-13 00:58:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:58:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14286
Author: @quantumnic
Created: 2/16/2026
Status: 🔄 Open

Base: main ← Head: fix/bugfixes

📝 Commits (1)

  • 414ea61 cmd: fix panic when model digest is shorter than 12 characters

📊 Changes

2 files changed (+11 additions, -3 deletions)

View changed files

📝 cmd/cmd.go (+10 -2)
📝 docs/faq.mdx (+1 -1)

📄 Description

Summary

Two bug fixes:

1. Fix panic in ollama list / ollama ps with short digests (Fixes #14250)

ListHandler and ProcessHandler unconditionally slice m.Digest[:12] without checking the string length. If a model has a digest shorter than 12 characters (e.g. malformed manifest), this causes:

panic: runtime error: slice bounds out of range [:12] with length 3

Fix: Add a bounds check before slicing — show the full digest if it's shorter than 12 characters.

2. Fix broken GPU docs link in FAQ (Fixes #14243)

The FAQ links to ./gpu.mdx which results in a 404 on the docs site. Changed to ./gpu to match the docs routing.

Testing

  • Verified the digest slicing logic handles short strings correctly
  • Verified the docs link format matches other working links in the docs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14286 **Author:** [@quantumnic](https://github.com/quantumnic) **Created:** 2/16/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/bugfixes` --- ### 📝 Commits (1) - [`414ea61`](https://github.com/ollama/ollama/commit/414ea615cfe2b05ced8d962bb7fefed5b76a5ac1) cmd: fix panic when model digest is shorter than 12 characters ### 📊 Changes **2 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+10 -2) 📝 `docs/faq.mdx` (+1 -1) </details> ### 📄 Description ## Summary Two bug fixes: ### 1. Fix panic in `ollama list` / `ollama ps` with short digests (Fixes #14250) `ListHandler` and `ProcessHandler` unconditionally slice `m.Digest[:12]` without checking the string length. If a model has a digest shorter than 12 characters (e.g. malformed manifest), this causes: ``` panic: runtime error: slice bounds out of range [:12] with length 3 ``` **Fix:** Add a bounds check before slicing — show the full digest if it's shorter than 12 characters. ### 2. Fix broken GPU docs link in FAQ (Fixes #14243) The FAQ links to `./gpu.mdx` which results in a 404 on the docs site. Changed to `./gpu` to match the docs routing. ## Testing - Verified the digest slicing logic handles short strings correctly - Verified the docs link format matches other working links in the docs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:58:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#14602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?