mirror of
https://github.com/moghtech/komodo.git
synced 2026-03-09 07:13:36 -05:00
[Feature] Improve Komodo to Periphery authentication #87
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @metril on GitHub (Oct 13, 2024).
Connections from Komodo to each Periphery should use unique authentication. Currently, the same passkey needs to be specified for each Periphery. If a Periphery host were to be hacked, the passkey will be compromised and thus require changing the passkey on each and every host. Additionally this puts other hosts at risk until the passkey can be changed.
The passkeys should be hashed via something like bcrypt. Additionally, consider implementing mutual TLS.
@wwwlicious commented on GitHub (Oct 25, 2024):
It would be a nicer UX imo if the "create server" flow generated a unique key that you then provide to the periphery.
I've used this flow in other server/agent stacks, often along with inverting where the url is set so each periphery has the server key and url and on first startup the agent handshakes/auths and registers with the server.
@mbecker20 commented on GitHub (Oct 6, 2025):
https://github.com/moghtech/komodo/pull/889