Add or_else to allow attempt to connect to docker socket proxy via http if local connection fails, as per #87.
This was tested by adding env var DOCKER_HOST to the compose.env file (picked up by periphery container, which is run as a non-root user without the docker.sock volume defined), creating a new stack in Komodo (using redis image), then deploying. Deployment was successful, however the stack is marked as down in Komodo. I double-checked that the periphery agent is able to view running containers and the logs of those containers by exec-ing into the container and running the commands, so I am unsure where the issue lies.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/moghtech/komodo/pull/131
**Author:** [@Svagtlys](https://github.com/Svagtlys)
**Created:** 10/16/2024
**Status:** ✅ Merged
**Merged:** 10/17/2024
**Merged by:** [@mbecker20](https://github.com/mbecker20)
**Base:** `main` ← **Head:** `Docker-Socket-Proxy-via-HTTP-Connection`
---
### 📝 Commits (2)
- [`2ec7fea`](https://github.com/moghtech/komodo/commit/2ec7fea6e04b8f10eb5351da850371653b5ac2e8) Update docker.rs to allow http docker socket connection
- [`8f1c8d8`](https://github.com/moghtech/komodo/commit/8f1c8d8996dc413ade484b7718de38a9af62490a) Update docker.rs
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `bin/periphery/src/docker.rs` (+1 -1)
</details>
### 📄 Description
Add or_else to allow attempt to connect to docker socket proxy via http if local connection fails, as per #87.
This was tested by adding env var DOCKER_HOST to the compose.env file (picked up by periphery container, which is run as a non-root user without the docker.sock volume defined), creating a new stack in Komodo (using redis image), then deploying. Deployment was successful, however the stack is marked as down in Komodo. I double-checked that the periphery agent is able to view running containers and the logs of those containers by exec-ing into the container and running the commands, so I am unsure where the issue lies.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/moghtech/komodo/pull/131
Author: @Svagtlys
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @mbecker20
Base:
main← Head:Docker-Socket-Proxy-via-HTTP-Connection📝 Commits (2)
2ec7feaUpdate docker.rs to allow http docker socket connection8f1c8d8Update docker.rs📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
bin/periphery/src/docker.rs(+1 -1)📄 Description
Add or_else to allow attempt to connect to docker socket proxy via http if local connection fails, as per #87.
This was tested by adding env var DOCKER_HOST to the compose.env file (picked up by periphery container, which is run as a non-root user without the docker.sock volume defined), creating a new stack in Komodo (using redis image), then deploying. Deployment was successful, however the stack is marked as down in Komodo. I double-checked that the periphery agent is able to view running containers and the logs of those containers by exec-ing into the container and running the commands, so I am unsure where the issue lies.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.