mirror of
https://github.com/moghtech/komodo.git
synced 2026-05-05 15:34:09 -05:00
Docker login before compose pull #832
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/komodo#832
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @febalist on GitHub (Aug 20, 2024).
During the deploy stack process, I encounter an “access forbidden” error at the compose pull stage:
It looks like docker login isn’t happening before compose pull, even though config.registry_account is set up.
In the code, I noticed that in /bin/periphery/src/compose.rs, docker login happens after compose pull. It might need to be swapped to ensure login happens first.
Core 1.13.3
Periphery 1.13.3
@mbecker20 commented on GitHub (Aug 20, 2024):
You are correct, thanks for the Report! Fixed in this commit: https://github.com/mbecker20/monitor/commit/a2758ce6f4c557b52ec8acb49e929648c4d48c91
I'm building 1.13.4 now to address this issue, will release shortly. Thanks for your interest in the project!
@mbecker20 commented on GitHub (Aug 20, 2024):
Hey, the lastest release is out and should fix the issue.
https://github.com/mbecker20/monitor/releases/tag/v1.13.4
@febalist commented on GitHub (Aug 20, 2024):
Thank you for the quick fix! The project looks incredibly useful and convenient.