[PR #832] [MERGED] Fix persistent table sorting state including unsorted #5650

New Issue

GiteaMirror · 2026-04-22T00:47:34-05:00

GiteaMirror commented

2026-04-22 00:47:34 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/832
Author: @MP-Tool
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @mbecker20

Base: 1.19.4 ← Head: feat/persistent-stacks-sorting

📝 Commits (1)

f103cc2 feat: persist all table sorting states including unsorted

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 frontend/src/ui/data-table.tsx (+1 -3)

📄 Description

Problem

Stack sorting preferences do not persist across page reloads. When a user sorts stacks alphabetically or reverse-alphabetically and then switches back to unsorted and navigates away or reloads the page, the sorting is lost. More specifically, when the table is in "unsorted" state (showing "-" in column header), it incorrectly reverts to the previous sorted state (e.g., reverse-alphabetical) after page reload.

Solution

Removed conditional check in localStorage saving logic to always persist sorting state
Now saves empty sorting array ([]) for "unsorted" state instead of skipping it
Ensures all table sorting states are consistently preserved across page reloads
Applies to all DataTable components throughout the application

Fixes #816

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/832 **Author:** [@MP-Tool](https://github.com/MP-Tool) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `1.19.4` ← **Head:** `feat/persistent-stacks-sorting` --- ### 📝 Commits (1) - [`f103cc2`](https://github.com/moghtech/komodo/commit/f103cc239e972a5f1f927972eefd3cd0ce7f8003) feat: persist all table sorting states including unsorted ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/ui/data-table.tsx` (+1 -3) </details> ### 📄 Description ## Problem Stack sorting preferences do not persist across page reloads. When a user sorts stacks alphabetically or reverse-alphabetically and then switches back to unsorted and navigates away or reloads the page, the sorting is lost. More specifically, when the table is in "unsorted" state (showing "-" in column header), it incorrectly reverts to the previous sorted state (e.g., reverse-alphabetical) after page reload. ## Solution - Removed conditional check in localStorage saving logic to always persist sorting state - Now saves empty sorting array (`[]`) for "unsorted" state instead of skipping it - Ensures all table sorting states are consistently preserved across page reloads - Applies to all DataTable components throughout the application Fixes #816 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-22 00:47:35 -05:00

GiteaMirror closed this issue

2026-04-22 00:47:35 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#5650