difference between assign and use public ip

This commit is contained in:
mbecker20
2024-01-16 03:25:57 -08:00
parent 453600a70c
commit d8ff64c1d9
4 changed files with 10 additions and 3 deletions

4
Cargo.lock generated
View File

@@ -2959,9 +2959,9 @@ dependencies = [
[[package]]
name = "serror"
version = "0.1.6"
version = "0.1.7"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "eefe7ba3cfc7e288ae60ca1e2ba2104acabb96dcadb9ec40ece559876529a163"
checksum = "9e07f96f2a8cc7225cf79027fb2c62fd7497e872fa27ee895b8e61f5746d886b"
dependencies = [
"anyhow",
"axum",

View File

@@ -57,6 +57,7 @@ impl State {
security_group_ids,
key_pair_name,
assign_public_ip,
use_public_ip,
} = config.into();
let instance_type = handle_unknown_instance_type(
InstanceType::from(instance_type.as_str()),
@@ -122,7 +123,7 @@ impl State {
let state_name =
get_ec2_instance_state_name(&client, &instance_id).await?;
if state_name == Some(InstanceStateName::Running) {
let ip = if assign_public_ip {
let ip = if use_public_ip {
get_ec2_instance_public_ip(&client, &instance_id).await?
} else {
instance

View File

@@ -36,6 +36,7 @@ pub struct LaunchAwsServerConfig {
pub security_group_ids: Vec<String>,
pub key_pair_name: String,
pub assign_public_ip: bool,
pub use_public_ip: bool,
}
#[typeshare]
@@ -65,6 +66,7 @@ impl From<&AwsBuilderConfig> for LaunchAwsServerConfig {
security_group_ids: value.security_group_ids.clone(),
key_pair_name: value.key_pair_name.clone(),
assign_public_ip: value.assign_public_ip,
use_public_ip: value.use_public_ip,
}
}
}

View File

@@ -112,6 +112,9 @@ impl BuilderConfig {
assign_public_ip: partial
.assign_public_ip
.unwrap_or(config.assign_public_ip),
use_public_ip: partial
.use_public_ip
.unwrap_or(config.use_public_ip),
github_accounts: partial
.github_accounts
.unwrap_or(config.github_accounts),
@@ -162,6 +165,7 @@ pub struct AwsBuilderConfig {
pub security_group_ids: Vec<String>,
pub key_pair_name: String,
pub assign_public_ip: bool,
pub use_public_ip: bool,
#[serde(default)]
pub github_accounts: Vec<String>,