M M Arif
ce35d6e746
Merge branch 'bottomsheets-actions-search-filters-apilimit-tags' of codeberg.org:gitnex/GitNex into bottomsheets-actions-search-filters-apilimit-tags
2022-04-22 11:17:57 +05:00
M M Arif
a0dce0a812
Merge branch 'main' into bottomsheets-actions-search-filters-apilimit-tags
...
# Conflicts:
# app/src/main/res/values/strings.xml
2022-04-22 11:16:14 +05:00
a05216e18a
Add support for team repos ( #1113 )
...
* view team repos
* add team repos
* removing does not work due to missing APIs
Closes #7 and replaces https://codeberg.org/gitnex/GitNex/pulls/701
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1113
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-21 23:02:59 +02:00
M M Arif
15e01e5c81
Merge branch 'main' into bottomsheets-actions-search-filters-apilimit-tags
2022-04-20 21:02:25 +02:00
3f7706de23
Fix visible actions and teams tab ( #1112 )
...
Closes #1071
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1112
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-20 15:46:50 +02:00
M M Arif
d4d0f4ddc2
Add common actions where required
2022-04-20 18:07:52 +05:00
M M Arif
0ed9d95b4d
Move issue/pr screen bottomsheet to new UI
2022-04-20 16:59:41 +05:00
M M Arif
42f8cb0915
wip on bottomsheets
2022-04-19 23:11:34 +05:00
M M Arif
3053fff8c6
Add pr info and icons to due date and ms
2022-04-19 21:34:51 +05:00
M M Arif
e5ec6f4431
Remote search issues, pr API does not have q param yet.
2022-04-19 17:49:24 +05:00
M M Arif
4f7200cb72
Implement page settings from API and remove old instance var holders.
2022-04-19 17:20:21 +05:00
M M Arif
8aeb413b82
Remove static calls from viewmodels
2022-04-19 16:16:10 +05:00
M M Arif
49a532e462
reload tags after delete and new tag, other minor fixes
2022-04-19 15:42:03 +05:00
M M Arif
463a5eed4d
Extend my issues with assigned to me filter
2022-04-18 20:59:37 +05:00
M M Arif
dd7908ab8c
Fix explore repos and users
2022-04-18 18:39:22 +05:00
fbe55035f2
Move to tea4j-autodeploy ( #1088 )
...
Move to https://codeberg.org/GitNex/tea4j-autodeploy as Retrofit interfaces. Closes #907 closes #1084
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1088
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-18 09:10:54 +02:00
c04e1dc584
Fix crash on new app ( #1082 )
...
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: 6543 <6543@noreply.codeberg.org >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1082
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-09 11:23:49 +02:00
5b5919c1f6
Add some basic instrumentation tests ( #1105 )
...
Add some tests to test Android-only features: `MainActivityTest` (just start the activity), `AppUtilTest` (some Android-related methods), `ToastyTest` (only to test if toasts are working). Actually, this doesn't really test something, but just as a first step.
https://codeberg.org/gitnex/GitNex/issues/1098
I think it's REALLY hard to write tests that really work well in testing features. Starting activities is possible, but it's hard to test it. Also, this will run with the same database and tinydb the real app uses - it's hard for us to make this usable, we have to replace the DB and TinyDB and then add values again.
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1105
Reviewed-by: 6543 <6543@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-07 20:58:09 +02:00
M M Arif and M M Arif
885bfc5d1f
UI enhancements and Refactors ( #1102 )
...
As title
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1102
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-06 17:27:02 +02:00
42f6611585
Use another docker image ( #1103 )
...
Try to fix our issues with gitlab ci.
# DISCLAIMER
I don't really know if this will work. I pulled the image locally and ran it, `apksigner` is available, `./gradlew assembleFreeRelease` runs without issues, but I don't know if this will behave differently on gitlab. However, this took a long time to run because it is installing an emulator and sdk tools, don't know why.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1103
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-04 18:47:40 +02:00
M M Arif and M M Arif
5c0950d287
Use paginations ( #1089 )
...
Closes #278
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1089
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-04 10:00:54 +02:00
M M Arif and M M Arif
6654ba4abd
Filter my issues and use remote search ( #1091 )
...
Closes #1090
- [x] Filter my issues
- [x] Add search to my issues
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1091
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-04-04 09:32:03 +02:00
M M Arif and M M Arif
1e7a0a20b2
Show labels in list / show draft status for release ( #1083 )
...
Closes #258
Closes #877
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1083
2022-03-28 19:57:47 +02:00
M M Arif and M M Arif
18fd368c8d
Update gradle, move maven repo to project gradle file ( #1097 )
...
I would also like to remove `jcenter()` but right now two repositories are using it.
`com.pes.materialcolorpicker:library` `com.amulyakhare:com.amulyakhare.textdrawable`
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1097
2022-03-28 16:37:36 +02:00
fea6457358
Add system theme ( #1095 )
...
* Add new themes `Follow system (Light/Dark)` (new default) and `Follow system (Light/Pitch Black)` that follows system color scheme -> closes https://codeberg.org/gitnex/GitNex/issues/961
* also fixes `In Settings ->Appearance, the theme and time shows wrong values. Also the time selection is not shown upon theme change.` in https://codeberg.org/gitnex/GitNex/issues/1084
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1095
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-27 20:47:08 +02:00
8ff0c337a3
Updates ( #1094 )
...
**basic gradle stuff**
* Android gradle plugin to 7.0.0
* gradle to 7.4.1
**dependencies**
* gson to 2.9.0
* stormpot to 3.1 (has breaking changes)
* commons io to 2.11.0 (has breaking changes)
* guava to 31.1
* acra to 5.8.4 (has breaking changes)
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1094
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-27 20:41:20 +02:00
062fb9e9fd
Fix commit crash ( #1096 )
...
Fixes another null pointer crash on commits. You can try this on our emoji-java fork, it will crash on `main`.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1096
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-27 11:58:33 +02:00
M M Arif and M M Arif
84e8850d9f
My issues / update assignees list ( #1087 )
...
Closes #745
Closes #200
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1087
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-18 09:57:24 +01:00
M M Arif and M M Arif
5761c3519e
UI improvements and clean ups ( #1074 )
...
This PR mostly intend to improve and re visualize the UI across the app including clean up of layouts and strings.
Some UI changes are experimental like bottom sheet grid layout for repo items and can be extended once mature enough for use.
Few screen shots attached.
Closes #1077
Closes #976
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1074
Reviewed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-18 09:56:49 +01:00
7e514041bb
Don't use TinyDB as cache ( #1034 )
...
Do not use TinyDB as a cache or a way to send data between activities.
### How is this working
Instead of saving everything into the TinyDB, I created three `Context`s (a `RepositoryContext`, an `IssueContext` and an `AccountContext`). All are used to store things like API or database values/models and additional data, e.g. the `RepositoryContext` also contains information about the current filter state of a repository (issues, pull requests, releases/tags and milestones). These are sent using `Intent`s and `Bundle`s between activities and fragments. Changing a field (e.g. filter state) in any fragment changes it also for the whole repository (or at least it should do so).
Due to the size of the changes (after https://codeberg.org/gitnex/GitNex/commit/c9172f85efafd9f25739fdd8385e1904b711ea41 , Git says `154 files changed, 3318 insertions(+), 3835 deletions(-)`) **I highly recommend you to create a beta/pre release before releasing a stable version**.
Additional changes:
* after logging out, the account remains in the account list (with a note) and you can log in again (you can't switch to this account)
* repositories and organizations are clickable on user profiles
* deleted two unused classes
Once finished, hopefully
* closes #354
* replaces #897
* fixes #947
* closes #1001
* closes #1015
* marks #876 and #578 as `Wontfix` since they are not necessary at this point
* and all the other TinyDB issues
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1034
Reviewed-by: 6543 <6543@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-13 03:59:13 +01:00
ea30556844
Add single commit screen with diff ( #1048 )
...
Also addresses the already closed #946
Closes https://codeberg.org/gitnex/GitNex/issues/335
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1048
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-09 12:52:34 +01:00
ff41e82baf
Fix notifications list ( #1067 )
...
There was a missing notifyDataSetChanged() call. Fixes #1054
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1067
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-05 19:56:12 +01:00
qwerty287 and M M Arif
db8e47168d
Fix reactions UI ( #1069 )
...
Frontport of #1065
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1069
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-05 11:42:32 +01:00
6d0f4dcc1f
Fix repo website opening ( #1061 )
...
As discussed on discord, but this only fixes opening a repo's website and not issue if "open supported links" option is enabled.
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1061
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-04 15:03:16 +01:00
2a46c68d3d
Fix accounts displaying ( #1064 )
...
Clear the accounts list before adding new ones.
Hopefully closes #1058 but I couldn't really test it because I don't have this issue without the patch.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1064
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-03-04 14:44:39 +01:00
M M Arif and M M Arif
f7897041e4
Prepare for next dev ( #1051 )
...
As title
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1051
2022-02-27 15:10:24 +01:00
M M Arif and M M Arif
96b5665c89
Prepare release 4.2.0 ( #1050 )
...
As title
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1050
2022-02-27 14:02:09 +01:00
0dc22a65be
Crowdin 2022-02-26 ( #1049 )
...
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1049
Reviewed-by: 6543 <6543@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-26 19:13:44 +01:00
37bc1968d4
Prefer Runnables over local interfaces ( #1047 )
...
Prefer the `Runnable` interface instead of interfaces without any parameters. Addresses #1000
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1047
Reviewed-by: 6543 <6543@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-25 23:35:51 +01:00
2f4af03c99
Fix CI... ( #1046 )
...
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1046
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-23 09:49:14 +01:00
ae70d5b111
Update strings ( #1045 )
...
Use a %s instead of + to check CI
The resource key was changed to avoid issues with other languages if they do not have the %s in the string, they'll just use the English variant.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1045
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-23 09:20:04 +01:00
aaafe881c1
Fix push step ( #1044 )
...
The filename was not correct. (Running this right now won't start the push step, I can search for unused strings I can delete in this PR so it will be triggered.)
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1044
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-23 09:11:35 +01:00
aa30aba794
Clean up strings to test CI ( #1043 )
...
Deleted 3 unused strings.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1043
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-23 08:44:40 +01:00
1214954ed3
gitlab ci: add locales stage ( #1042 )
...
nit fix
Co-authored-by: 6543 <6543@obermui.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1042
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: 6543 <6543@noreply.codeberg.org >
Co-committed-by: 6543 <6543@noreply.codeberg.org >
2022-02-22 16:03:07 +01:00
245998e36b
Push translations via CI ( #1041 )
...
Automatically push translation files to Crowdin when pushing changes to the strings.xml file (only English).
Addresses #141
@mmarif You have to add a new secret to gitlab ci, `CROWDIN_TOKEN`, that contains the crowdin api token.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1041
Reviewed-by: 6543 <6543@noreply.codeberg.org >
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-22 15:03:00 +01:00
56ff09d44d
Cherry-pick changes from #897 ( #1032 )
...
Cherry-pick enhancements and features from #897 . I didn't pick database-related stuff because I don't think it's a good idea to do this (see discord conversation).
Closes #598
Closes #887
Closes #888
Closes #901
Closes #1024
Closes #1035
Co-authored-by: opyale <opyale@noreply.codeberg.org >
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1032
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-22 07:23:46 +01:00
24c7176753
Link to pipeline instead of overview ( #1038 )
...
See https://docs.gitlab.com/ee/ci/variables/predefined_variables.html . Links to the exact pipeline instead of the pipeline overview.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1038
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-19 09:50:15 +01:00
33fdff5f4d
Fix INI highlighting ( #1037 )
...
My fork has native support for INI files (https://codeberg.org/qwerty287/Prism4j/commit/5ad2176c5f128f9367021f8ccf5971206d566607 ).
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1037
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-14 07:09:55 +01:00
00efc968b9
Add static badges to assets ( #1036 )
...
To limit connections to other server's some people might not want.
Co-authored-by: qwerty287 <ndev@web.de >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1036
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-13 19:10:24 +01:00
f79d227bff
Add support for tags ( #1002 )
...
Closes #983
TODO
- [x] create tags
- [x] view tags
- [x] apply pagination
- [x] delete tags
Co-authored-by: qwerty287 <ndev@web.de >
Co-authored-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: M M Arif <mmarif@swatian.com >
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1002
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org >
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org >
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org >
2022-02-12 14:41:11 +01:00
M M Arif
