github-starred/gitnex
2
0
Fork 0
mirror of https://github.com/gitnex-org/gitnex.git synced 2026-07-21 06:44:49 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improvements from the review

Browse Source
This commit is contained in:
M M Arif
2022-04-22 14:44:18 +05:00
parent ce35d6e746
commit 2ef559ccba
8 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/org/mian/gitnex/activities/AddNewAccountActivity.java
+1 -1
View File
@@ -41,7 +41,7 @@ public class AddNewAccountActivity extends BaseActivity {
private String spinnerSelectedValue;
private Version giteaVersion;
private int maxResponseItems = 50;
private int defaultPagingNumber = 25;
private int defaultPagingNumber = 30;
@Override
public void onCreate(Bundle savedInstanceState) {
app/src/main/java/org/mian/gitnex/database/db/GitnexDatabase.java
+1 -1
View File
@@ -57,7 +57,7 @@ public abstract class GitnexDatabase extends RoomDatabase {
@Override
public void migrate(@NonNull SupportSQLiteDatabase database) {
database.execSQL("ALTER TABLE 'userAccounts' ADD COLUMN 'maxResponseItems' INTEGER NOT NULL DEFAULT 50");
database.execSQL("ALTER TABLE 'userAccounts' ADD COLUMN 'defaultPagingNumber' INTEGER NOT NULL DEFAULT 25");
database.execSQL("ALTER TABLE 'userAccounts' ADD COLUMN 'defaultPagingNumber' INTEGER NOT NULL DEFAULT 30");
}
};
app/src/main/java/org/mian/gitnex/fragments/BottomSheetSingleIssueFragment.java
+5 -1
View File
@@ -249,7 +249,11 @@ public class BottomSheetSingleIssueFragment extends BottomSheetDialogFragment {
binding.commentReactionButtons.setVisibility(View.GONE);
binding.reactionDivider.setVisibility(View.GONE);
binding.bottomSheetHeaderFrame.setVisibility(View.GONE);
binding.issuePrDivider.setVisibility(View.GONE);
binding.mergePullRequest.setVisibility(View.GONE);
binding.updatePullRequest.setVisibility(View.GONE);
if(issue.getIssueType().equalsIgnoreCase("issue")) {
binding.issuePrDivider.setVisibility(View.GONE);
}
}
else if(!canPush) {
binding.addRemoveAssignees.setVisibility(View.GONE);
app/src/main/res/layout/bottom_sheet_issue_comments.xml
+1 -1
View File
@@ -165,7 +165,7 @@
android:gravity="center"
app:layout_alignSelf="flex_start"
app:drawableTopCompat="@drawable/ic_browser"
android:text="@string/isOpen"
android:text="@string/openInBrowser"
android:textColor="?attr/primaryTextColor"
android:textSize="16sp" />
app/src/main/res/layout/bottom_sheet_organization.xml
+1 -1
View File
@@ -154,7 +154,7 @@
android:gravity="center"
app:layout_alignSelf="flex_start"
app:drawableTopCompat="@drawable/ic_browser"
android:text="@string/isOpen"
android:text="@string/openInBrowser"
android:textColor="?attr/primaryTextColor"
android:textSize="16sp" />
app/src/main/res/layout/bottom_sheet_repo.xml
+1 -1
View File
@@ -259,7 +259,7 @@
app:layout_alignSelf="flex_start"
android:gravity="center"
app:drawableTopCompat="@drawable/ic_browser"
android:text="@string/isOpen"
android:text="@string/openInBrowser"
android:textColor="?attr/primaryTextColor"
android:textSize="16sp" />
app/src/main/res/layout/bottom_sheet_single_issue.xml
+4 -2
View File
@@ -85,6 +85,7 @@
app:drawableTopCompat="@drawable/ic_pull_request"
android:text="@string/mergePullRequestButtonText"
android:textColor="?attr/primaryTextColor"
android:visibility="gone"
android:textSize="16sp" />
<TextView
@@ -98,6 +99,7 @@
app:drawableTopCompat="@drawable/ic_update"
android:text="@string/newUpdateButtonCopy"
android:textColor="?attr/primaryTextColor"
android:visibility="gone"
android:textSize="16sp" />
<TextView
@@ -109,7 +111,7 @@
android:gravity="center"
app:layout_alignSelf="flex_start"
app:drawableTopCompat="@drawable/ic_branch"
android:text="@string/menuDeleteText"
android:text="@string/deleteBranch"
android:textColor="?attr/primaryTextColor"
android:textSize="16sp" />
@@ -245,7 +247,7 @@
android:gravity="center"
app:layout_alignSelf="flex_start"
app:drawableTopCompat="@drawable/ic_browser"
android:text="@string/isOpen"
android:text="@string/openInBrowser"
android:textColor="?attr/primaryTextColor"
android:textSize="16sp" />
app/src/main/res/values/strings.xml
+2
View File
@@ -505,6 +505,7 @@
<string name="addRemove">Add / Remove</string>
<string name="download">Download</string>
<string name="reopen">Reopen</string>
<string name="openInBrowser">Open in Browser</string>
<!-- generic copy -->
<string name="exploreUsers">Explore users</string>
@@ -553,6 +554,7 @@
<string name="mergeStrategy">Merge Strategy</string>
<string name="selectMergeStrategy">Select merge strategy</string>
<string name="mergeNotAllowed">Not allowed to merge [Reason: Does not have enough approvals]</string>
<string name="deleteBranch">Delete Branch</string>
<string name="waitLoadingDownloadFile">Please wait for the file to load to memory</string>
<string name="downloadFileSaved">File saved successfully</string>