github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

PR inline comments shown off by one line #6465

New Issue
Closed
opened 2025-11-02 06:56:51 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 06:56:51 -06:00
Owner
Copy Link

Originally created by @noerw on GitHub (Dec 5, 2020).

  • Gitea version (or commit ref): 1.14.0+dev-290-gb1cf7f4df (current gitea.com)

Description

In the main view of a PR, inline comments are attached to one line below where they were created

Screenshots

PR files view
grafik

PR main view
grafik

Originally created by @noerw on GitHub (Dec 5, 2020). - Gitea version (or commit ref): 1.14.0+dev-290-gb1cf7f4df (current gitea.com) ## Description In the main view of a PR, inline comments are attached to one line below where they were created ## Screenshots PR files view ![grafik](https://user-images.githubusercontent.com/7880552/101267094-1b011f80-374d-11eb-8d77-e639688efdfb.png) PR main view ![grafik](https://user-images.githubusercontent.com/7880552/101267100-35d39400-374d-11eb-9e84-12d3aceb1e2d.png)
GiteaMirror added the type/bugissue/duplicate labels 2025-11-02 06:56:52 -06:00
GiteaMirror commented 2025-11-02 06:56:52 -06:00
Author
Owner
Copy Link

@noerw commented on GitHub (Dec 5, 2020):

Actually, the line this is attached to does not exist at all in the final PR, only in an intermediate commit (which was pushed earlier than the comment was made)

example from above is https://gitea.com/gitea/tea/pulls/264/files#issuecomment-121110

@noerw commented on GitHub (Dec 5, 2020): Actually, the line this is attached to does not exist at all in the final PR, only in an intermediate commit (which was pushed earlier than the comment was made) example from above is https://gitea.com/gitea/tea/pulls/264/files#issuecomment-121110
GiteaMirror commented 2025-11-02 06:56:53 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Dec 6, 2020):

Same as #13683 I think.

@jpraet commented on GitHub (Dec 6, 2020): Same as #13683 I think.
GiteaMirror commented 2025-11-02 06:56:53 -06:00
Author
Owner
Copy Link

@noerw commented on GitHub (Dec 6, 2020):

indeed, thank you. closing as duplicate

@noerw commented on GitHub (Dec 6, 2020): indeed, thank you. closing as duplicate
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/duplicate type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#6465
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?