PowerShell git hooks do not work on 7.2+ #13683

@colejohnson66 commented on GitHub (Nov 6, 2024):

I was able to hack a solution by changing the shebang from pwsh to bash. I can't see a reason they'd need to be executed in PowerShell instead of Git Bash.

@colejohnson66 commented on GitHub (Nov 6, 2024): I was able to hack a solution by changing the shebang from `pwsh` to `bash`. I can't see a reason they'd *need* to be executed in PowerShell instead of Git Bash.

GiteaMirror commented

@lunny commented on GitHub (Nov 6, 2024):

You can change the SCRIPT_TYPE. https://docs.gitea.com/administration/config-cheat-sheet#repository-repository

@lunny commented on GitHub (Nov 6, 2024): You can change the `SCRIPT_TYPE`. https://docs.gitea.com/administration/config-cheat-sheet#repository-repository

GiteaMirror commented

b573512312/modules/repository/hooks.go (L16-L106)

@colejohnson66 commented on GitHub (Nov 6, 2024):

Yeah. I was digging through the code to see where they're generated, and I saw it uses setting.ScriptType

However, considering scripts run under Git Bash (on Windows), is there any reason to support PowerShell ones? It would be less maintenance, in the long run, to just always use bash.

@colejohnson66 commented on GitHub (Nov 6, 2024): Yeah. I was digging through the code to see where they're generated, and I saw it uses `setting.ScriptType` https://github.com/go-gitea/gitea/blob/b573512312d82e894db7aac89f4938a6b61e1e70/modules/repository/hooks.go#L16-L106 However, considering scripts run under Git Bash (on Windows), is there any reason to support PowerShell ones? It would be less maintenance, in the long run, to just always use bash.

GiteaMirror commented

@lunny commented on GitHub (Nov 6, 2024):

I think the default value is bash if you haven't changed it.

@lunny commented on GitHub (Nov 6, 2024): I think the default value is `bash` if you haven't changed it.

GiteaMirror commented

https://github.com/go-gitea/gitea/pull/31058#issuecomment-2131290276

@wxiaoguang commented on GitHub (Nov 7, 2024):

It is powershell's problem and can not be easily bypassed.

There could be some workarounds:

(And one more thing: ask Microsoft to ignore the file extension check or add an argument for PowerShell to ignore the file extension check.)

@wxiaoguang commented on GitHub (Nov 7, 2024): It is powershell's problem and can not be easily bypassed. There could be some workarounds: https://github.com/go-gitea/gitea/pull/31058#issuecomment-2131290276 (And one more thing: ask Microsoft to ignore the file extension check or add an argument for PowerShell to ignore the file extension check.)

GiteaMirror commented

@colejohnson66 commented on GitHub (Nov 7, 2024):

Yes, the ideal solution would be for Microsoft to revert the change. But it’s been two years since they said they’d consider it and haven’t given any updates. Perhaps the Gitea docs should be updated to warn against this?

@colejohnson66 commented on GitHub (Nov 7, 2024): Yes, the ideal solution would be for Microsoft to revert the change. But it’s been two years since they said they’d consider it and haven’t given any updates. Perhaps the Gitea docs should be updated to warn against this?

GiteaMirror commented

@GiteaBot commented on GitHub (Dec 8, 2024):

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot commented on GitHub (Dec 8, 2024): We close issues that need feedback from the author if there were no new comments for a month. :tea:

GiteaMirror commented

@colejohnson66 commented on GitHub (Dec 8, 2024):

Wow

@colejohnson66 commented on GitHub (Dec 8, 2024): Wow

GiteaMirror commented

@wxiaoguang commented on GitHub (Dec 8, 2024):

There are workarounds: https://github.com/go-gitea/gitea/pull/31058#issuecomment-2131290276

@wxiaoguang commented on GitHub (Dec 8, 2024): There are workarounds: https://github.com/go-gitea/gitea/pull/31058#issuecomment-2131290276

GiteaMirror commented

@colejohnson66 commented on GitHub (Dec 9, 2024):

Until a proper solution is available, I still think the documentation should be updated to warn against this.

@colejohnson66 commented on GitHub (Dec 9, 2024): Until a proper solution is available, I still think the documentation should be updated to warn against this.

GiteaMirror commented

@wxiaoguang commented on GitHub (Dec 9, 2024):

To be honest I have no idea about how to document it since I do not use Windows or PowerShell.

Would you like to propose some updates? https://gitea.com/gitea/docs/pulls

@wxiaoguang commented on GitHub (Dec 9, 2024): To be honest I have no idea about how to document it since I do not use Windows or PowerShell. Would you like to propose some updates? https://gitea.com/gitea/docs/pulls

GiteaMirror commented

@GiteaBot commented on GitHub (Jan 8, 2025):

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot commented on GitHub (Jan 8, 2025): We close issues that need feedback from the author if there were no new comments for a month. :tea:

GiteaMirror commented