API: PR #9452 made breaking changes #6226

Closed
opened 2025-11-02 06:49:03 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @PhilippHomann on GitHub (Oct 29, 2020).

  • Gitea version (or commit ref): v1.12.5
  • Git version: does not matter
  • Operating system: linux (docker on CentOS)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No, but just because I haven't found any user with more than 30 repos
  • Log gist:

Description

PR #9452 added pagination to several API calls.
This change was meant to be non-breaking, but as @richmahn already mentioned in the PRs comments, it is!
Even when not using pagination in the API query the default pagination (DEFAULT_PAGING_NUM) is used, which defaults to 30.

In my use case this breaks the jenkins plugin, which caused my jenkins instance to delete jobs....
Currently worked around that by setting DEFAULT_PAGING_NUM to 999, but I think we should prevent others from stumbling on this..

@SpaWn2KiLl @zeripath

Originally created by @PhilippHomann on GitHub (Oct 29, 2020). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): v1.12.5 - Git version: does not matter - Operating system: linux (docker on CentOS) - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No, but just because I haven't found any user with more than 30 repos - Log gist: ## Description PR #9452 added pagination to several API calls. This change was meant to be non-breaking, but as @richmahn already mentioned in the PRs comments, it is! Even when not using pagination in the API query the default pagination (DEFAULT_PAGING_NUM) is used, which defaults to 30. In my use case this breaks the [jenkins plugin](https://github.com/jenkinsci/gitea-plugin/), which caused my jenkins instance to delete jobs.... Currently worked around that by setting DEFAULT_PAGING_NUM to 999, but I think we should prevent others from stumbling on this.. @SpaWn2KiLl @zeripath
Author
Owner

@zeripath commented on GitHub (Oct 29, 2020):

There is a pull request to https://github.com/jenkinsci/gitea-plugin/pull/25 fix this.

@zeripath commented on GitHub (Oct 29, 2020): There is a pull request to https://github.com/jenkinsci/gitea-plugin/pull/25 fix this.
Author
Owner

@zeripath commented on GitHub (Oct 29, 2020):

I was sure that this was a duplicate but I can't quite find the issue related to this.

@zeripath commented on GitHub (Oct 29, 2020): I was sure that this was a duplicate but I can't quite find the issue related to this.
Author
Owner

@6543 commented on GitHub (Oct 31, 2020):

@PhilippHomann If you have an issue with a specific api pleace create an issue.

Since v1.12.x has been released quite some time, adding a breaking changes lable to the pull wont make anything different.

I'll close this issue because I can not detect a specific issue nor some proposal - hope #9452 didn't breake too mouch for you :)

@6543 commented on GitHub (Oct 31, 2020): @PhilippHomann If you have an issue with a specific api pleace create an issue. Since v1.12.x has been released quite some time, adding a breaking changes lable to the pull wont make anything different. I'll close this issue because I can not detect a specific issue nor some proposal - hope #9452 didn't breake too mouch for you :)
Author
Owner

@PhilippHomann commented on GitHub (Oct 31, 2020):

Fine for me as I found a workaround until the plugin is patched.
Just wanted to report that issue as I haven't found one in giteas issues that prevents someone else from doing long research :)

@PhilippHomann commented on GitHub (Oct 31, 2020): Fine for me as I found a workaround until the plugin is patched. Just wanted to report that issue as I haven't found one in giteas issues that prevents someone else from doing long research :)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#6226