github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Open issue count not updated when closing through commits/PR merges #4971

New Issue
Closed
opened 2025-11-02 06:09:34 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 06:09:34 -06:00
Owner
Copy Link

Originally created by @bkraul on GitHub (Feb 28, 2020).

Description

Issue count indicators are not being properly updated when the issues are closed via commit messages or PR merges.

Steps to reproduce:

  • Create a new issue.
  • Add a commit to the project wit the Closes #... instruction.
  • Push the commit.
  • The issue will close as expected.
  • The count of open issues will not be updated and you will still see the count as if the issue had not been closed.
  • Restarting (recreating the docker container) updates the count.
    ...

Screenshots

Issue created:

image

Committing and pushing the change:

image

Issue closes, but count is not updated:

image
image

This issue appears related to #10360, and was supposed to have been fixed by #10364 but it seems it is not.

Originally created by @bkraul on GitHub (Feb 28, 2020). - Gitea version (or commit ref): ge0ecddc11 - Git version: 1.12.0+dev-401 - Operating system: N/A - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes: https://try.gitea.io/bkraul/TestProject/issues/ - [ ] No - [ ] Not relevant - Log gist: ## Description Issue count indicators are not being properly updated when the issues are closed via commit messages or PR merges. Steps to reproduce: * Create a new issue. * Add a commit to the project wit the `Closes #...` instruction. * Push the commit. * The issue will close as expected. * The count of open issues will not be updated and you will still see the count as if the issue had not been closed. * Restarting (recreating the docker container) updates the count. ... ## Screenshots ### Issue created: ![image](https://user-images.githubusercontent.com/14616851/75561658-fed99080-5a0c-11ea-9ca7-2e87860cf870.png) ### Committing and pushing the change: ![image](https://user-images.githubusercontent.com/14616851/75561826-3cd6b480-5a0d-11ea-90e8-f9ab97448e1d.png) ### Issue closes, but count is not updated: ![image](https://user-images.githubusercontent.com/14616851/75561923-6394eb00-5a0d-11ea-8661-974c63434629.png) ![image](https://user-images.githubusercontent.com/14616851/75561969-77405180-5a0d-11ea-9ac1-1d070d566763.png) This issue appears related to #10360, and was supposed to have been fixed by #10364 but it seems it is not.
GiteaMirror added the type/bug label 2025-11-02 06:09:34 -06:00
GiteaMirror commented 2025-11-02 06:09:35 -06:00
Author
Owner
Copy Link

@solaristhesun commented on GitHub (Mar 11, 2020):

Please fix this. It makes me mad :/

@solaristhesun commented on GitHub (Mar 11, 2020): Please fix this. It makes me mad :/
GiteaMirror commented 2025-11-02 06:09:35 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Sep 19, 2020):

OK it looks to me like the correct values are calculated but then they are incorrectly overwritten by another call to update repository...

@zeripath commented on GitHub (Sep 19, 2020): OK it looks to me like the correct values are calculated but then they are incorrectly overwritten by another call to update repository...
GiteaMirror commented 2025-11-02 06:09:36 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Sep 19, 2020):

89c94e2f8e/services/repository/push.go (L362-L365)

Updates all the columns of the repository - overwriting the updated values.

@zeripath commented on GitHub (Sep 19, 2020): https://github.com/go-gitea/gitea/blob/89c94e2f8e871028492d5460fd3a10794f4ced1b/services/repository/push.go#L362-L365 Updates all the columns of the repository - overwriting the updated values.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4971
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?