[PR #4971] [MERGED] Fix layout of the topics editing form #17572

New Issue

GiteaMirror · 2025-11-02T14:08:59-06:00

GiteaMirror commented

2025-11-02 14:08:59 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4971
Author: @kzmi
Created: 9/21/2018
Status: ✅ Merged
Merged: 9/29/2018
Merged by: @lafriks

Base: master ← Head: fix_manage_topics_done_button

📝 Commits (3)

3569777 Fix layout of the topic edit.
ef2c1ed Improve switching visibility of the topic edit
f6e024e Merge remote-tracking branch 'upstream/master' into fix_manage_topics_done_button

📊 Changes

4 files changed (+5 additions, -6 deletions)

View changed files

📝 public/css/index.css (+1 -1)
📝 public/js/index.js (+2 -2)
📝 public/less/_repository.less (+0 -1)
📝 templates/repo/home.tmpl (+2 -2)

📄 Description

With Chinese or Japanese translation, "Done" button in the topics editing form is not displayed as a single line.

(Simplified Chinese)

Expected result is:

Cause

The form uses Semantic UI Grid, and the right-hand column has too short width for displaying a button.

After clicking "Manage Topics", the editing form is shown using jQuery's .show(). But it breaks functionarity of Semantic UI Grid because "display: block" style will be set. The style of the grid should be "display: flex".
If the style of the grid was "display: block", right-hand column specified as "two wide column" will be wrapped to the next line.

This PR fixes 1 and 2.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4971 **Author:** [@kzmi](https://github.com/kzmi) **Created:** 9/21/2018 **Status:** ✅ Merged **Merged:** 9/29/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix_manage_topics_done_button` --- ### 📝 Commits (3) - [`3569777`](https://github.com/go-gitea/gitea/commit/35697770b25f4334a7056f68e679e06523a0404e) Fix layout of the topic edit. - [`ef2c1ed`](https://github.com/go-gitea/gitea/commit/ef2c1ed9a5dc9f6d2a31715b4af25681e1465775) Improve switching visibility of the topic edit - [`f6e024e`](https://github.com/go-gitea/gitea/commit/f6e024e76475d81076d8d1a909d8243d0b30d59e) Merge remote-tracking branch 'upstream/master' into fix_manage_topics_done_button ### 📊 Changes **4 files changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `public/css/index.css` (+1 -1) 📝 `public/js/index.js` (+2 -2) 📝 `public/less/_repository.less` (+0 -1) 📝 `templates/repo/home.tmpl` (+2 -2) </details> ### 📄 Description With Chinese or Japanese translation, "Done" button in the topics editing form is not displayed as a single line. (Simplified Chinese) ![btn-simplified_chinese](https://user-images.githubusercontent.com/3753969/45875816-bce9fb00-bdd3-11e8-8841-793c88c6fcd2.png) Expected result is: ![expected](https://user-images.githubusercontent.com/3753969/45875898-fc184c00-bdd3-11e8-8733-5b2a8d83fd9d.png) ### Cause 1. The form uses Semantic UI Grid, and the right-hand column has too short width for displaying a button. ![current-layout](https://user-images.githubusercontent.com/3753969/45878103-e35f6480-bdda-11e8-8255-49ae26da1709.png) 2. After clicking "Manage Topics", the editing form is shown using jQuery's .show(). But it breaks functionarity of Semantic UI Grid because "display: block" style will be set. The style of the grid should be "display: flex". If the style of the grid was "display: block", right-hand column specified as "two wide column" will be wrapped to the next line. This PR fixes 1 and 2. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:09:00 -06:00

GiteaMirror closed this issue

2025-11-02 14:09:05 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17572