Double borders on edit file view #443

Closed
opened 2025-11-02 03:23:39 -06:00 by GiteaMirror · 5 comments
Owner

Originally created by @pgaskin on GitHub (Mar 9, 2017).

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (Just edit any file)
  • Log gist: Not relevant

Description

There is unnecessary double borders around the editors on the edit file view. This applies to both the markdown and the plain text editor.

This CSS code will fix it:

.repository.file.editor .tab[data-tab="write"] {
    padding: 0 !important;
}
.repository.file.editor .tab[data-tab="write"] .editor-toolbar {
    border: none !important;
}
.repository.file.editor .tab[data-tab="write"] .CodeMirror {
    border-left: none;
    border-right: none;
    border-bottom: none;
}

Screenshots

Before modifications After modifications
screenshot screenshot 1
Originally created by @pgaskin on GitHub (Mar 9, 2017). - Gitea version (or commit ref): - Git version: - Operating system: - Database (use `[x]`): - [X] SQLite - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (Just edit any file) - Log gist: Not relevant ## Description There is unnecessary double borders around the editors on the edit file view. This applies to both the markdown and the plain text editor. This CSS code will fix it: ````css .repository.file.editor .tab[data-tab="write"] { padding: 0 !important; } .repository.file.editor .tab[data-tab="write"] .editor-toolbar { border: none !important; } .repository.file.editor .tab[data-tab="write"] .CodeMirror { border-left: none; border-right: none; border-bottom: none; } ```` ## Screenshots |Before modifications|After modifications| |-|-| |![screenshot](https://cloud.githubusercontent.com/assets/13909717/23731039/29b40998-0439-11e7-8bea-b1f3c00a7aac.png)|![screenshot 1](https://cloud.githubusercontent.com/assets/13909717/23731038/29b23fdc-0439-11e7-8cce-fa5614f34013.png)|
GiteaMirror added the topic/ui label 2025-11-02 03:23:39 -06:00
Author
Owner

@lunny commented on GitHub (Mar 9, 2017):

Why change the style? How the new one is better than old one?

@lunny commented on GitHub (Mar 9, 2017): Why change the style? How the new one is better than old one?
Author
Owner

@pgaskin commented on GitHub (Mar 9, 2017):

The new one is more clean, and saves space. It is also more consistent with GitHub and the rest of the Gitea UI.

@pgaskin commented on GitHub (Mar 9, 2017): The new one is more clean, and saves space. It is also more consistent with GitHub and the rest of the Gitea UI.
Author
Owner

@pgaskin commented on GitHub (Mar 9, 2017):

I have submitted PR #1153

@pgaskin commented on GitHub (Mar 9, 2017): I have submitted PR #1153
Author
Owner

@pgaskin commented on GitHub (Mar 9, 2017):

@lunny, could this go into 1.1.0, or is that one finished for now?

@pgaskin commented on GitHub (Mar 9, 2017): @lunny, could this go into 1.1.0, or is that one finished for now?
Author
Owner

@lunny commented on GitHub (Mar 9, 2017):

I think this should not be taken to v1.1, or we will never address 1.1. 1.1 has only 1 bug left.

@lunny commented on GitHub (Mar 9, 2017): I think this should not be taken to v1.1, or we will never address 1.1. 1.1 has only 1 bug left.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#443