[PR #443] [MERGED] UpdateIssueUsersByMentions was calling database write operations while #15384

New Issue

GiteaMirror · 2025-11-02T11:45:21-06:00

GiteaMirror commented

2025-11-02 11:45:21 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/443
Author: @lunny
Created: 12/22/2016
Status: ✅ Merged
Merged: 12/22/2016
Merged by: @lunny

Base: master ← Head: lunny/fix_db_context

📝 Commits (1)

8c3e73b UpdateIssueUsersByMentions was calling database write operations while

📊 Changes

3 files changed (+13 additions, -11 deletions)

View changed files

📝 models/issue.go (+7 -7)
📝 models/issue_comment.go (+5 -3)
📝 models/issue_mail.go (+1 -1)

📄 Description

a transaction session was in progress. MailParticipants was failing
silently because of the SQLITE_LOCKED error. Make sure failures in
MailParticipants enter the log, and pass on the transaction context.

issue: let caller pass in database context, and use it
issue_comment: obtain database context to pass to UpdateIssueMentions
issue_comment: log any error from call to MailParticipants
issue_mail: pass on database context to UpdateIssueMentions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/443 **Author:** [@lunny](https://github.com/lunny) **Created:** 12/22/2016 **Status:** ✅ Merged **Merged:** 12/22/2016 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `lunny/fix_db_context` --- ### 📝 Commits (1) - [`8c3e73b`](https://github.com/go-gitea/gitea/commit/8c3e73bd94e42703952ea4838ed581d4628a09ca) UpdateIssueUsersByMentions was calling database write operations while ### 📊 Changes **3 files changed** (+13 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+7 -7) 📝 `models/issue_comment.go` (+5 -3) 📝 `models/issue_mail.go` (+1 -1) </details> ### 📄 Description a transaction session was in progress. MailParticipants was failing silently because of the SQLITE_LOCKED error. Make sure failures in MailParticipants enter the log, and pass on the transaction context. issue: let caller pass in database context, and use it issue_comment: obtain database context to pass to UpdateIssueMentions issue_comment: log any error from call to MailParticipants issue_mail: pass on database context to UpdateIssueMentions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 11:45:21 -06:00

GiteaMirror closed this issue

2025-11-02 11:45:21 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#15384