Several versions of xorm included in go.sum #3864

Closed
opened 2025-11-02 05:28:49 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @guillep2k on GitHub (Aug 28, 2019).

I don't know if this is a problem, but I've noticed several versions of xorm in go.sum:

13388258a4/go.sum (L148-L155)

Everything started when I wanted to reference this commit: Add insert select where in #7898.

I did that by editing go.mod like:

github.com/go-xorm/xorm master
xorm.io/core master

And then running make vendor.

There's been some discussion at the #maintainers chat about this, and it's been suggested that @lafriks updated github.com/lafriks/xormstore (which he did).

However, I couldn't figure out the right way to update go.mod, as I kept getting even more versions of go-xorm/xorm in my go.sum.

So I desisted of making any changes and report this here, so people with better understanding of this can solve it (if necessary) or simply ignore it.

Originally created by @guillep2k on GitHub (Aug 28, 2019). I don't know if this is a problem, but I've noticed several versions of xorm in go.sum: https://github.com/go-gitea/gitea/blob/13388258a4ef1593784e8daf97506575cc284f61/go.sum#L148-L155 Everything started when I wanted to reference this commit: [Add insert select where](https://github.com/go-xorm/xorm/pull/1401) in #7898. I did that by editing `go.mod` like: ``` github.com/go-xorm/xorm master xorm.io/core master ``` And then running `make vendor`. There's been some discussion at the `#maintainers` chat about this, and it's been suggested that @lafriks updated [github.com/lafriks/xormstore](https://github.com/lafriks/xormstore) (which [he did](https://github.com/lafriks/xormstore/releases/tag/v1.2.0)). However, I couldn't figure out the right way to update `go.mod`, as I kept getting even more versions of `go-xorm/xorm` in my `go.sum`. So I desisted of making any changes and report this here, so people with better understanding of this can solve it (if necessary) or simply ignore it.
Author
Owner

@sapk commented on GitHub (Aug 28, 2019):

GO111MODULE=on go get -u -v github.com/lafriks/xormstore@v1.2.0
GO111MODULE=on go mod tidy
GO111MODULE=on go mod vendor
git add vendor
@sapk commented on GitHub (Aug 28, 2019): ``` GO111MODULE=on go get -u -v github.com/lafriks/xormstore@v1.2.0 GO111MODULE=on go mod tidy GO111MODULE=on go mod vendor git add vendor ```
Author
Owner

@sapk commented on GitHub (Aug 28, 2019):

Ho
I just see that xorm v0.7.7 is not released yet and the ref v0.7.7-0.20190822154023-17592d96b35b point to a commit and not a release.

@sapk commented on GitHub (Aug 28, 2019): Ho I just see that xorm v0.7.7 is not released yet and the ref v0.7.7-0.20190822154023-17592d96b35b point to a commit and not a release.
Author
Owner

@sapk commented on GitHub (Aug 28, 2019):

The new version in xormstore is v0.7.6 so we still have two version in use in the wait for a tag on xorm.
Updating xormstore should still be done to align other db drivers

@sapk commented on GitHub (Aug 28, 2019): The new version in xormstore is v0.7.6 so we still have two version in use in the wait for a tag on xorm. Updating xormstore should still be done to align other db drivers
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3864