github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-10 05:32:52 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

CORS preflight OPTIONS request to API returns 404 #2752

New Issue
Closed
opened 2025-11-02 04:46:43 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-02 04:46:43 -06:00
Owner
Copy Link

Originally created by @salcedo on GitHub (Jan 14, 2019).

  • Gitea version (or commit ref): 1.6.1
  • Git version: 2.20.1
  • Operating system: OpenBSD 6.4
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I'm working on a project that will make some requests to Gitea's API. As my project is on a different origin, my browser sends a CORS preflight (an OPTIONS request).

Gitea doesn't handle an OPTIONS request, and returns 404.

How to fix?

Works:

curl -X GET https://git.example.com/api/v1/repos/search

Returns 404:

curl -X OPTIONS https://git.example.com/api/v1/repos/search

Screenshots

Originally created by @salcedo on GitHub (Jan 14, 2019). <!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.6.1 - Git version: 2.20.1 - Operating system: OpenBSD 6.4 - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description I'm working on a project that will make some requests to Gitea's API. As my project is on a different origin, my browser sends a CORS preflight (an OPTIONS request). Gitea doesn't handle an OPTIONS request, and returns 404. How to fix? ### Works: ``` curl -X GET https://git.example.com/api/v1/repos/search ``` ### Returns 404: ``` curl -X OPTIONS https://git.example.com/api/v1/repos/search ``` ## Screenshots <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the issue/confirmedtype/enhancement labels 2025-11-02 04:46:43 -06:00
GiteaMirror commented 2025-11-02 04:46:44 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Jan 14, 2019):

Closed as duplicate of #5700

There is a PR in works to resolve this

@techknowlogick commented on GitHub (Jan 14, 2019): Closed as duplicate of #5700 There is a PR in works to resolve this
GiteaMirror commented 2025-11-02 04:46:44 -06:00
Author
Owner
Copy Link

@JuhoHeiskanen commented on GitHub (Jan 23, 2019):

This issue is technically not a duplicate since #5700 deals with the git smart http protocol, not the Gitea API. Pull #5719 that closed the "duplicate" issue does not resolve this one.

@JuhoHeiskanen commented on GitHub (Jan 23, 2019): This issue is technically not a duplicate since #5700 deals with the git smart http protocol, not the Gitea API. Pull #5719 that closed the "duplicate" issue does not resolve this one.
GiteaMirror commented 2025-11-02 04:46:44 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Jan 23, 2019):

Access-Control-Allow-Origin header And OPTIONS method response were implemented with that ticket the users purpose may have been for different purposes but they indeed accomplished the same goal

@techknowlogick commented on GitHub (Jan 23, 2019): Access-Control-Allow-Origin header And OPTIONS method response were implemented with that ticket the users purpose may have been for different purposes but they indeed accomplished the same goal
GiteaMirror commented 2025-11-02 04:46:45 -06:00
Author
Owner
Copy Link

@JuhoHeiskanen commented on GitHub (Jan 23, 2019):

As far as I can tell, the Gitea API is unaffected by that change. The change does not seem to affect the /api/v1/repos/search endpoint.

@JuhoHeiskanen commented on GitHub (Jan 23, 2019): As far as I can tell, the Gitea API is unaffected by that change. The change does not seem to affect the `/api/v1/repos/search` endpoint.
GiteaMirror commented 2025-11-02 04:46:45 -06:00
Author
Owner
Copy Link

@JuhoHeiskanen commented on GitHub (Jan 23, 2019):

To be more clear, the pull did not implement CORS header support for the API, but it did implement support for them in git-over-http.

@JuhoHeiskanen commented on GitHub (Jan 23, 2019): To be more clear, the pull did not implement CORS header support for the API, but it did implement support for them in git-over-http.
GiteaMirror commented 2025-11-02 04:46:45 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Jan 23, 2019):

That’s helpful information. Thanks :)

@techknowlogick commented on GitHub (Jan 23, 2019): That’s helpful information. Thanks :)
GiteaMirror commented 2025-11-02 04:46:45 -06:00
Author
Owner
Copy Link

@FallingSnow commented on GitHub (Jan 31, 2019):

It seems that Gitea doesn't add cors headers to non-option requests either. Cors headers are required on both preflight OPTION requests as well as the following intended requests.

@FallingSnow commented on GitHub (Jan 31, 2019): It seems that Gitea doesn't add cors headers to non-option requests either. Cors headers are required on both preflight `OPTION` requests as well as the following intended requests.
GiteaMirror commented 2025-11-02 04:46:45 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Apr 1, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Apr 1, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:46:46 -06:00
Author
Owner
Copy Link

@klappy commented on GitHub (Apr 16, 2019):

Has anybody made progress or found a functional work around for this issue?

@klappy commented on GitHub (Apr 16, 2019): Has anybody made progress or found a functional work around for this issue?
GiteaMirror commented 2025-11-02 04:46:47 -06:00
Author
Owner
Copy Link

@techknowlogick commented on GitHub (Apr 16, 2019):

Current workaround would be to use a reverse proxy that intercepts the request needed and returns the appropriate response.

There is a pending PR for this, however it is awaiting updates from contributor.

@techknowlogick commented on GitHub (Apr 16, 2019): Current workaround would be to use a reverse proxy that intercepts the request needed and returns the appropriate response. There is a pending PR for this, however it is awaiting updates from contributor.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2752
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?