github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-06 02:02:32 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Highlighted diff emitting extraneous newlines #5700

New Issue
Closed
opened 2025-11-02 06:33:30 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 06:33:30 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (Jul 7, 2020).

Example: 03967f99a6

https://github.com/go-gitea/gitea/pull/12047 seems to cause text in diffs to sometimes split up a single line:

image

It should be

image

I think the issue is that either we or chroma are emitting newlines where there shouldn't be ones. Here's the raw HTML of line 2 line with three newlines present on a single actual line:

<span class="mono wrap">	npx ver 
<span class="added-code"><span class="err">-</span><span class="err">C</span> 
</span><span class="err">p</span><span class="err">a</span><span class="err">t</span><span class="err">c</span><span class="err">h</span>
</span>

cc: @mrsdizzie

Originally created by @silverwind on GitHub (Jul 7, 2020). Example: https://try.gitea.io/silverwind/updates/commit/03967f99a6cbb87c7ea7385d264ed42539b0162f https://github.com/go-gitea/gitea/pull/12047 seems to cause text in diffs to sometimes split up a single line: <img width="301" alt="image" src="https://user-images.githubusercontent.com/115237/86749618-ad39b600-c03d-11ea-8cd5-1930e8940194.png"> It should be <img width="313" alt="image" src="https://user-images.githubusercontent.com/115237/86749919-e3773580-c03d-11ea-9fe5-9f5843054616.png"> I think the issue is that either we or chroma are emitting newlines where there shouldn't be ones. Here's the raw HTML of line 2 line with three newlines present on a single actual line: ```` <span class="mono wrap"> npx ver <span class="added-code"><span class="err">-</span><span class="err">C</span> </span><span class="err">p</span><span class="err">a</span><span class="err">t</span><span class="err">c</span><span class="err">h</span> </span> ```` cc: @mrsdizzie
GiteaMirror added the type/bug label 2025-11-02 06:33:30 -06:00
GiteaMirror commented 2025-11-02 06:33:31 -06:00
Author
Owner
Copy Link

@mrsdizzie commented on GitHub (Jul 7, 2020):

Hmm weird it does seem to be happening somewhere in Chroma in the tokenizing stage. Put up a PR to just remove the added newline

@mrsdizzie commented on GitHub (Jul 7, 2020): Hmm weird it does seem to be happening somewhere in Chroma in the tokenizing stage. Put up a PR to just remove the added newline
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?