github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 21:53:50 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Critical bug: Attachments were accidentally deleted #1914

New Issue
Closed
opened 2025-11-02 04:17:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 04:17:43 -06:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jun 10, 2018).

  • Gitea version (or commit ref): 1.4.2 / af57d6a
  • Git version: N/A
  • Operating system: N/A
  • Database:
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist: N/A

Description

Steps to Reproduce

  1. Create repository: "Repo1"
  2. Create an issue and upload some attachments
    (https://try.gitea.io allow image/jpeg|image/png|application/zip|application/gzip)
  3. Create repository: "Repo2"
  4. Create an issue in "Repo2"
  5. Delete "Repo2"
  6. Any attachments uploaded to issue/release/PR were accidentally deleted from database and disk, no matter which user uploaded the files (Attachments uploaded to comment are not affected)

I think it's caused by #1092

af57d6ab8a/models/repo.go (L1845)

c.ID == 0 here
af57d6ab8a/models/issue_comment.go (L149-L155)

Screenshots

N/A

Originally created by @ghost on GitHub (Jun 10, 2018). - Gitea version (or commit ref): 1.4.2 / af57d6a - Git version: N/A - Operating system: N/A - Database: - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes ~~(provide example URL)~~ - [ ] No - [ ] Not relevant - Log gist: N/A ## Description Steps to Reproduce 1. Create repository: "Repo1" 2. Create an issue and upload some attachments (<https://try.gitea.io> allow `image/jpeg|image/png|application/zip|application/gzip`) 3. Create repository: "Repo2" 4. Create an issue in "Repo2" 5. Delete "Repo2" 6. Any attachments uploaded to issue/release/PR were accidentally deleted from database and disk, no matter which user uploaded the files (Attachments uploaded to comment are not affected) I think it's caused by #1092 https://github.com/go-gitea/gitea/blob/af57d6ab8a5a1f0f8bb3f52a081736c8c57cbd72/models/repo.go#L1845 `c.ID == 0` here https://github.com/go-gitea/gitea/blob/af57d6ab8a5a1f0f8bb3f52a081736c8c57cbd72/models/issue_comment.go#L149-L155 ## Screenshots N/A
GiteaMirror added the issue/criticaltype/bug labels 2025-11-02 04:17:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/critical type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?