[PR #4341] [MERGED] Fixes repo membership check in API #17337

New Issue

GiteaMirror · 2025-11-02T12:32:55-06:00

GiteaMirror commented

2025-11-02 12:32:55 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4341
Author: @cleverer
Created: 6/29/2018
Status: ✅ Merged
Merged: 7/5/2018
Merged by: @lunny

Base: master ← Head: patch-1

📝 Commits (2)

502ff85 Fixes repo membership check in API
011b897 Merge branch 'master' into patch-1

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 routers/api/v1/org/member.go (+1 -1)

📄 Description

Untested, since I can't compile (yet).

As far as I can see, this wasn't working properly. It first checks, if the User making the request is part of the organization (because privacy) and then went on to check the same again. I think it should check the user in the url now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4341 **Author:** [@cleverer](https://github.com/cleverer) **Created:** 6/29/2018 **Status:** ✅ Merged **Merged:** 7/5/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`502ff85`](https://github.com/go-gitea/gitea/commit/502ff857c5b281e9ee6bda066744abd5007640a9) Fixes repo membership check in API - [`011b897`](https://github.com/go-gitea/gitea/commit/011b897e276916eac59bd1841c458d5d156a6b1d) Merge branch 'master' into patch-1 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `routers/api/v1/org/member.go` (+1 -1) </details> ### 📄 Description Untested, since I can't compile (yet). As far as I can see, this wasn't working properly. It first checks, if the User making the request is part of the organization (because privacy) and then went on to check the same again. I think it should check the user in the url now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:32:55 -06:00

GiteaMirror closed this issue

2025-11-02 12:32:55 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17337