[PR #2071] [MERGED] Fix #1271: Call location.reload after XHR finishes #16212

New Issue

GiteaMirror · 2025-11-02T12:04:54-06:00

GiteaMirror commented

2025-11-02 12:04:54 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2071
Author: @knixeur
Created: 6/28/2017
Status: ✅ Merged
Merged: 6/28/2017
Merged by: @lunny

Base: master ← Head: fix1271

📝 Commits (1)

dd9842e Fix #1271: Call location.reload after XHR finishes

📊 Changes

1 file changed (+4 additions, -8 deletions)

View changed files

📝 public/js/index.js (+4 -8)

📄 Description

location.reload was being called when the related dropdown
was hidden, even if a request initiated before to update this
value hadn't finished. This caused troubles on Firefox.

Please check the following:

Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2071 **Author:** [@knixeur](https://github.com/knixeur) **Created:** 6/28/2017 **Status:** ✅ Merged **Merged:** 6/28/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `fix1271` --- ### 📝 Commits (1) - [`dd9842e`](https://github.com/go-gitea/gitea/commit/dd9842eb750ae405c9c003847b98f5cef666be99) Fix #1271: Call location.reload after XHR finishes ### 📊 Changes **1 file changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `public/js/index.js` (+4 -8) </details> ### 📄 Description location.reload was being called when the related dropdown was hidden, even if a request initiated before to update this value hadn't finished. This caused troubles on Firefox. Please check the following: 1. Make sure you are targeting the `master` branch, pull requests on release branches are only allowed for bug fixes. 2. Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md 3. Describe what your pull request does and which issue you're targeting (if any) **You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 12:04:54 -06:00

GiteaMirror closed this issue

2025-11-02 12:04:54 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#16212