github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #1832] [MERGED] Fix pull request compare link #16072

New Issue
Closed
opened 2025-11-02 12:01:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 12:01:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/1832
Author: @ethantkoenig
Created: 5/29/2017
Status: ✅ Merged
Merged: 5/31/2017
Merged by: @appleboy

Base: master ← Head: fix_compare

📝 Commits (2)

📊 Changes

3 files changed (+41 additions, -2 deletions)

View changed files

➕ integrations/pull_compare_test.go (+31 -0)
📝 models/fixtures/repo_unit.yml (+9 -1)
📝 templates/repo/home.tmpl (+1 -1)

📄 Description

The link should be parentOwner/parent/compare/master...childOwner:master instead of parentOwner/parent/compare/master...parentOwner:master.

Without this fix, the owner of the child repo gets a 404 when they click on the compare-pull-request button on the parent repo's homepage.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/1832 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 5/29/2017 **Status:** ✅ Merged **Merged:** 5/31/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `fix_compare` --- ### 📝 Commits (2) - [`2df13e1`](https://github.com/go-gitea/gitea/commit/2df13e1f96ea3d5e98ba70b2dc687feee9a6f452) Fix pull request compare link - [`519c14c`](https://github.com/go-gitea/gitea/commit/519c14c3defd309abbf3ca28c3fbccebeb397111) Integration test ### 📊 Changes **3 files changed** (+41 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `integrations/pull_compare_test.go` (+31 -0) 📝 `models/fixtures/repo_unit.yml` (+9 -1) 📝 `templates/repo/home.tmpl` (+1 -1) </details> ### 📄 Description The link should be `parentOwner/parent/compare/master...childOwner:master` instead of `parentOwner/parent/compare/master...parentOwner:master`. Without this fix, the owner of the child repo gets a 404 when they click on the compare-pull-request button on the parent repo's homepage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:01:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?