fix(security): pin minimum TLS version in get_domain_from_ssl

ssl.create_default_context() already excludes TLS1/1.1 by default in
modern Python/OpenSSL, but CodeQL flags the implicit reliance on that
default. Pin minimum_version explicitly instead of leaving it to
library defaults.
This commit is contained in:
dextmorgn
2026-08-26 00:36:02 +02:00
parent 6b01f108f4
commit bb0dfa99f5
2 changed files with 2 additions and 0 deletions
+1
View File
@@ -188,6 +188,7 @@ def extract_input_schema_flow(model: Type[BaseModel]) -> Dict[str, Any]:
def get_domain_from_ssl(ip: str, port: int = 443) -> str | None:
try:
context = ssl.create_default_context()
context.minimum_version = ssl.TLSVersion.TLSv1_2
with socket.create_connection((ip, port), timeout=3) as sock:
with context.wrap_socket(sock, server_hostname=ip) as ssock:
cert = ssock.getpeercert()
@@ -240,6 +240,7 @@ def extract_input_schema_flow(model: Type[BaseModel]) -> Dict[str, Any]:
def get_domain_from_ssl(ip: str, port: int = 443) -> str | None:
try:
context = ssl.create_default_context()
context.minimum_version = ssl.TLSVersion.TLSv1_2
with socket.create_connection((ip, port), timeout=3) as sock:
with context.wrap_socket(sock, server_hostname=ip) as ssock:
cert = ssock.getpeercert()