github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #57] [MERGED] [core] Fix Modal Bottom Sheet Size for Images #61

New Issue
Closed
opened 2025-10-31 16:56:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:56:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/57
Author: @ricoberger
Created: 10/30/2023
Status: ✅ Merged
Merged: 10/30/2023
Merged by: @ricoberger

Base: main ← Head: core-fix-modal-bottom-sheet-size-for-images

📝 Commits (1)

  • 38fc4eb [core] Fix Modal Bottom Sheet Size for Images

📊 Changes

3 files changed (+9 additions, -0 deletions)

View changed files

📝 app/lib/widgets/item/details/utils/item_description.dart (+3 -0)
📝 app/lib/widgets/item/details/utils/item_media.dart (+3 -0)
📝 app/lib/widgets/item/details/utils/item_media_gallery.dart (+3 -0)

📄 Description

The size of the modal bottom sheet to display images had always a max width of 640px on large screens. This wasn't intended an the modal bottom sheet should fill the whole screen. This is now fixed, so that when a user clicks on an image in the details view of an item, the whole screen is used to display the image.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/57 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/30/2023 **Status:** ✅ Merged **Merged:** 10/30/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-fix-modal-bottom-sheet-size-for-images` --- ### 📝 Commits (1) - [`38fc4eb`](https://github.com/feeddeck/feeddeck/commit/38fc4ebc6c6a4603532edccf0ae11b6f52a4e2d4) [core] Fix Modal Bottom Sheet Size for Images ### 📊 Changes **3 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/item/details/utils/item_description.dart` (+3 -0) 📝 `app/lib/widgets/item/details/utils/item_media.dart` (+3 -0) 📝 `app/lib/widgets/item/details/utils/item_media_gallery.dart` (+3 -0) </details> ### 📄 Description The size of the modal bottom sheet to display images had always a max width of 640px on large screens. This wasn't intended an the modal bottom sheet should fill the whole screen. This is now fixed, so that when a user clicks on an image in the details view of an item, the whole screen is used to display the image. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#61
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?