[PR #53] [MERGED] [core] Improve Tabs Handling in Small Deck Layout #57

Closed
opened 2025-10-31 16:56:28 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/53
Author: @ricoberger
Created: 10/28/2023
Status: Merged
Merged: 10/28/2023
Merged by: @ricoberger

Base: mainHead: core-improve-tabs-handling-in-small-deck-layout


📝 Commits (1)

  • b83ffdf [core] Improve Tabs Handling in Small Deck Layout

📊 Changes

5 files changed (+75 additions, -8 deletions)

View changed files

📝 app/lib/main.dart (+2 -0)
app/lib/repositories/layout_repository.dart (+12 -0)
📝 app/lib/widgets/deck/deck_layout_large.dart (+16 -5)
📝 app/lib/widgets/deck/deck_layout_small.dart (+36 -0)
📝 app/lib/widgets/settings/decks/settings_decks_select.dart (+9 -3)

📄 Description

This commit improves the handling of tabs in the samll deck layout. We are now saving the selected tabs index in the newly added "LayoutRepository" so that we can reuse the selected tab when a user switches between the small and large layout. We can now also set the tab which should be initially selected in the large layout when a user selects a column in the navigation rail. Last but not least we can also reset the initial tab index when a user selects a new deck in the settings, so that we always display the first column instead of the column with the same index as it was selected in the previous deck.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/53 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 10/28/2023 **Status:** ✅ Merged **Merged:** 10/28/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-improve-tabs-handling-in-small-deck-layout` --- ### 📝 Commits (1) - [`b83ffdf`](https://github.com/feeddeck/feeddeck/commit/b83ffdf191b6fccf57332e935e8e2230c3c03e27) [core] Improve Tabs Handling in Small Deck Layout ### 📊 Changes **5 files changed** (+75 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/main.dart` (+2 -0) ➕ `app/lib/repositories/layout_repository.dart` (+12 -0) 📝 `app/lib/widgets/deck/deck_layout_large.dart` (+16 -5) 📝 `app/lib/widgets/deck/deck_layout_small.dart` (+36 -0) 📝 `app/lib/widgets/settings/decks/settings_decks_select.dart` (+9 -3) </details> ### 📄 Description This commit improves the handling of tabs in the samll deck layout. We are now saving the selected tabs index in the newly added "LayoutRepository" so that we can reuse the selected tab when a user switches between the small and large layout. We can now also set the tab which should be initially selected in the large layout when a user selects a column in the navigation rail. Last but not least we can also reset the initial tab index when a user selects a new deck in the settings, so that we always display the first column instead of the column with the same index as it was selected in the previous deck. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:56:28 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#57