github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-22 21:09:51 -05:00
Code Issues 23 Packages Projects Releases 8 Wiki Activity

[PR #249] [MERGED] [youtube] Fix Video Playback #520

New Issue
Closed
opened 2026-03-22 12:52:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 12:52:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/249
Author: @ricoberger
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @ricoberger

Base: main ← Head: youtube-fix-video-playback

📝 Commits (1)

  • 93b2ced [youtube] Fix Video Playback

📊 Changes

2 files changed (+100 additions, -82 deletions)

View changed files

📝 app/lib/widgets/item/details/utils/item_videos.dart (+48 -63)
📝 app/lib/widgets/item/details/utils/item_youtube/item_youtube_video_native.dart (+52 -19)

📄 Description

Until now we only checkeed if we could fetch a video which contains the
video and audio of a YouTube video. Since this is not always the case we
are now also returning the videos which do not contains the audio and
fetching the corresponding audio file seperatly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/249 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `youtube-fix-video-playback` --- ### 📝 Commits (1) - [`93b2ced`](https://github.com/feeddeck/feeddeck/commit/93b2ced5e0beb6d6ead21c66ada0edefac0f6d30) [youtube] Fix Video Playback ### 📊 Changes **2 files changed** (+100 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/item/details/utils/item_videos.dart` (+48 -63) 📝 `app/lib/widgets/item/details/utils/item_youtube/item_youtube_video_native.dart` (+52 -19) </details> ### 📄 Description Until now we only checkeed if we could fetch a video which contains the video and audio of a YouTube video. Since this is not always the case we are now also returning the videos which do not contains the audio and fetching the corresponding audio file seperatly. <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 12:52:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#520
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?