github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-08 22:52:02 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #259] [MERGED] Adjust Database Functions #249

New Issue
Closed
opened 2025-10-31 17:00:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 17:00:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/259
Author: @ricoberger
Created: 5/2/2025
Status: ✅ Merged
Merged: 5/2/2025
Merged by: @ricoberger

Base: main ← Head: adjust-database-functions

📝 Commits (1)

  • 0ef6500 Adjust Database Functions

📊 Changes

2 files changed (+174 additions, -0 deletions)

View changed files

📝 supabase/functions/_e2e/e2e_test.ts (+8 -0)
➕ supabase/migrations/20250502162957_adjust_database_functions.sql (+166 -0)

📄 Description

  • Set search_path for all database functions, as this is recommended
    by the Supabase security advisor
  • Fix items_delete functions: The function was never working, which
    caused that we saved to many items for a source, which slowed down our
    performance
  • Revoke execution rights for users for the sources_delete_files and
    items_delete functions
  • Add E2E test, to check if users can call the database functions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/259 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 5/2/2025 **Status:** ✅ Merged **Merged:** 5/2/2025 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `adjust-database-functions` --- ### 📝 Commits (1) - [`0ef6500`](https://github.com/feeddeck/feeddeck/commit/0ef6500e407127856a6a844f17f749efa51e226d) Adjust Database Functions ### 📊 Changes **2 files changed** (+174 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `supabase/functions/_e2e/e2e_test.ts` (+8 -0) ➕ `supabase/migrations/20250502162957_adjust_database_functions.sql` (+166 -0) </details> ### 📄 Description - Set `search_path` for all database functions, as this is recommended by the Supabase security advisor - Fix `items_delete` functions: The function was never working, which caused that we saved to many items for a source, which slowed down our performance - Revoke execution rights for users for the `sources_delete_files` and `items_delete` functions - Add E2E test, to check if users can call the database functions <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 17:00:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?