During the review of the submission of the iOS and macOS versions of FeedDeck we encountered some problems, so that the app was rejected. For that we had to make the following changes:
Change the foreground and background color of the "Sign in with Apple" button. This means we are now using black as foreground and white as background color.
Add the "Sign in with Apple" capability to the macOS version, to handle the sign in within the app as it is done for the iOS version.
Add description in the "CreateDeck" widget, because it was confusing for the review and they were thinking that they had to provide their name.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/feeddeck/feeddeck/pull/14
**Author:** [@ricoberger](https://github.com/ricoberger)
**Created:** 9/21/2023
**Status:** ✅ Merged
**Merged:** 9/22/2023
**Merged by:** [@ricoberger](https://github.com/ricoberger)
**Base:** `main` ← **Head:** `core-fix-issues-with-app-submission`
---
### 📝 Commits (1)
- [`38abdb6`](https://github.com/feeddeck/feeddeck/commit/38abdb61d8a19cd6aa943144df6f6fcff63f0738) [core] Fix Issues with App Submission
### 📊 Changes
**8 files changed** (+103 additions, -15 deletions)
<details>
<summary>View changed files</summary>
📝 `.github/workflows/continuous-delivery.yaml` (+1 -1)
📝 `app/lib/widgets/deck/actions/create_deck.dart` (+58 -0)
📝 `app/lib/widgets/signin/signin.dart` (+11 -12)
📝 `app/macos/Runner.xcodeproj/project.pbxproj` (+6 -1)
📝 `app/macos/Runner/DebugProfile.entitlements` (+4 -0)
📝 `app/macos/Runner/Release.entitlements` (+4 -0)
➕ `app/macos/Runner/RunnerDebug.entitlements` (+18 -0)
📝 `app/pubspec.yaml` (+1 -1)
</details>
### 📄 Description
During the review of the submission of the iOS and macOS versions of FeedDeck we encountered some problems, so that the app was rejected. For that we had to make the following changes:
- Change the foreground and background color of the "Sign in with Apple" button. This means we are now using black as foreground and white as background color.
- Add the "Sign in with Apple" capability to the macOS version, to handle the sign in within the app as it is done for the iOS version.
- Add description in the "CreateDeck" widget, because it was confusing for the review and they were thinking that they had to provide their name.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/feeddeck/feeddeck/pull/14
Author: @ricoberger
Created: 9/21/2023
Status: ✅ Merged
Merged: 9/22/2023
Merged by: @ricoberger
Base:
main← Head:core-fix-issues-with-app-submission📝 Commits (1)
38abdb6[core] Fix Issues with App Submission📊 Changes
8 files changed (+103 additions, -15 deletions)
View changed files
📝
.github/workflows/continuous-delivery.yaml(+1 -1)📝
app/lib/widgets/deck/actions/create_deck.dart(+58 -0)📝
app/lib/widgets/signin/signin.dart(+11 -12)📝
app/macos/Runner.xcodeproj/project.pbxproj(+6 -1)📝
app/macos/Runner/DebugProfile.entitlements(+4 -0)📝
app/macos/Runner/Release.entitlements(+4 -0)➕
app/macos/Runner/RunnerDebug.entitlements(+18 -0)📝
app/pubspec.yaml(+1 -1)📄 Description
During the review of the submission of the iOS and macOS versions of FeedDeck we encountered some problems, so that the app was rejected. For that we had to make the following changes:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.