github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #5] [MERGED] [core] Improve Media Handling #14

New Issue
Closed
opened 2025-10-31 16:55:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:55:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/5
Author: @ricoberger
Created: 9/8/2023
Status: ✅ Merged
Merged: 9/8/2023
Merged by: @ricoberger

Base: main ← Head: core-improve-media-handling

📝 Commits (1)

  • a52e50e [core] Improve Media Handling

📊 Changes

25 files changed (+112 additions, -374 deletions)

View changed files

➕ app/lib/utils/image_url.dart (+32 -0)
📝 app/lib/widgets/item/details/item_details_podcast.dart (+2 -17)
📝 app/lib/widgets/item/details/utils/item_media.dart (+2 -15)
📝 app/lib/widgets/item/details/utils/item_media_gallery.dart (+5 -33)
📝 app/lib/widgets/item/preview/item_preview_googlenews.dart (+2 -2)
📝 app/lib/widgets/item/preview/utils/item_media.dart (+2 -17)
📝 app/lib/widgets/item/preview/utils/item_media_gallery.dart (+2 -11)
📝 app/lib/widgets/item/preview/utils/item_source.dart (+3 -2)
📝 app/lib/widgets/source/source_icon.dart (+4 -37)
📝 supabase/functions/_shared/feed/github.ts (+13 -7)
📝 supabase/functions/_shared/feed/googlenews.ts (+4 -14)
📝 supabase/functions/_shared/feed/mastodon.ts (+3 -10)
📝 supabase/functions/_shared/feed/medium.ts (+6 -18)
📝 supabase/functions/_shared/feed/nitter.ts (+3 -10)
📝 supabase/functions/_shared/feed/podcast.ts (+3 -8)
📝 supabase/functions/_shared/feed/reddit.ts (+4 -14)
📝 supabase/functions/_shared/feed/rss.ts (+5 -17)
📝 supabase/functions/_shared/feed/stackoverflow.ts (+2 -5)
📝 supabase/functions/_shared/feed/tumblr.ts (+4 -14)
📝 supabase/functions/_shared/feed/utils/uploadFile.ts (+0 -22)

...and 5 more files

📄 Description

Improve the media handling within the app. We do not save the media files for items to the Supabase storage anymore. The source icons are now only saved in the Supabase storage, the usage of an url as source icon is not possible anymore.

The media files for items are directly retrieved from the corresponding url or for the web version from the "image-proxy-v1" Supabase function. If the image is retireved from the Supabase function we cache the image in the browser via the cache control headers. If the image is directly retrieved from it's url it's cached by the "CachedNetworkImage" widget.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/5 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 9/8/2023 **Status:** ✅ Merged **Merged:** 9/8/2023 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-improve-media-handling` --- ### 📝 Commits (1) - [`a52e50e`](https://github.com/feeddeck/feeddeck/commit/a52e50ec31d7c1c87d0e4d95a843469c6f5a22c7) [core] Improve Media Handling ### 📊 Changes **25 files changed** (+112 additions, -374 deletions) <details> <summary>View changed files</summary> ➕ `app/lib/utils/image_url.dart` (+32 -0) 📝 `app/lib/widgets/item/details/item_details_podcast.dart` (+2 -17) 📝 `app/lib/widgets/item/details/utils/item_media.dart` (+2 -15) 📝 `app/lib/widgets/item/details/utils/item_media_gallery.dart` (+5 -33) 📝 `app/lib/widgets/item/preview/item_preview_googlenews.dart` (+2 -2) 📝 `app/lib/widgets/item/preview/utils/item_media.dart` (+2 -17) 📝 `app/lib/widgets/item/preview/utils/item_media_gallery.dart` (+2 -11) 📝 `app/lib/widgets/item/preview/utils/item_source.dart` (+3 -2) 📝 `app/lib/widgets/source/source_icon.dart` (+4 -37) 📝 `supabase/functions/_shared/feed/github.ts` (+13 -7) 📝 `supabase/functions/_shared/feed/googlenews.ts` (+4 -14) 📝 `supabase/functions/_shared/feed/mastodon.ts` (+3 -10) 📝 `supabase/functions/_shared/feed/medium.ts` (+6 -18) 📝 `supabase/functions/_shared/feed/nitter.ts` (+3 -10) 📝 `supabase/functions/_shared/feed/podcast.ts` (+3 -8) 📝 `supabase/functions/_shared/feed/reddit.ts` (+4 -14) 📝 `supabase/functions/_shared/feed/rss.ts` (+5 -17) 📝 `supabase/functions/_shared/feed/stackoverflow.ts` (+2 -5) 📝 `supabase/functions/_shared/feed/tumblr.ts` (+4 -14) 📝 `supabase/functions/_shared/feed/utils/uploadFile.ts` (+0 -22) _...and 5 more files_ </details> ### 📄 Description Improve the media handling within the app. We do not save the media files for items to the Supabase storage anymore. The source icons are now only saved in the Supabase storage, the usage of an url as source icon is not possible anymore. The media files for items are directly retrieved from the corresponding url or for the web version from the "image-proxy-v1" Supabase function. If the image is retireved from the Supabase function we cache the image in the browser via the cache control headers. If the image is directly retrieved from it's url it's cached by the "CachedNetworkImage" widget. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:55:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#14
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?