github-starred/feeddeck
2
0
Fork 0
mirror of https://github.com/feeddeck/feeddeck.git synced 2026-03-09 07:02:01 -05:00
Code Issues 5 Packages Projects Releases 8 Wiki Activity

[PR #148] [MERGED] [core] Fix Blockquote Style #148

New Issue
Closed
opened 2025-10-31 16:58:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 16:58:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/feeddeck/feeddeck/pull/148
Author: @ricoberger
Created: 2/23/2024
Status: ✅ Merged
Merged: 2/23/2024
Merged by: @ricoberger

Base: main ← Head: core-improve-blockquote-style

📝 Commits (1)

  • e3ca09c [core] Fix Blockquote Style

📊 Changes

2 files changed (+18 additions, -0 deletions)

View changed files

📝 app/lib/widgets/item/details/utils/item_description.dart (+9 -0)
📝 app/lib/widgets/item/preview/utils/item_description.dart (+9 -0)

📄 Description

This commit fixes the style of blockquotes when we render the item description as Markdown. Until now blockquotes had a weird blue background, so that the text wasn't readable.

Now we are using the surface color as background and we add a border on the left site with the primary color.

We would also like to use italic as font family, but there is currently a bug, so that the defined blockquote style is not applied. See https://github.com/flutter/flutter/issues/81720

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/feeddeck/feeddeck/pull/148 **Author:** [@ricoberger](https://github.com/ricoberger) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 2/23/2024 **Merged by:** [@ricoberger](https://github.com/ricoberger) **Base:** `main` ← **Head:** `core-improve-blockquote-style` --- ### 📝 Commits (1) - [`e3ca09c`](https://github.com/feeddeck/feeddeck/commit/e3ca09c3f2c24fb7e6be56f869f80dfa3b97bdb1) [core] Fix Blockquote Style ### 📊 Changes **2 files changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/lib/widgets/item/details/utils/item_description.dart` (+9 -0) 📝 `app/lib/widgets/item/preview/utils/item_description.dart` (+9 -0) </details> ### 📄 Description This commit fixes the style of blockquotes when we render the item description as Markdown. Until now blockquotes had a weird blue background, so that the text wasn't readable. Now we are using the surface color as background and we add a border on the left site with the primary color. We would also like to use italic as font family, but there is currently a bug, so that the defined blockquote style is not applied. See https://github.com/flutter/flutter/issues/81720 <!-- Keep PR title verbose enough and add prefix telling about what source it touches e.g "[rss] Add feature xyz" or if the the PR is not realated to a source use "[core]", e.g. "[core] Fix xyz". If you add a breaking change within your PR you should add ":warning:" to the title, e.g. ":warning: [core] My breaking change" --> <!-- Description of what have been changed. Please also reference an issue, when available. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 16:58:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/feeddeck#148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?